Re: [PATCH 3/7] rtc: Convert struct i2c_msg initialization to C99 format

2012-09-17 Thread Julia Lawall
On Tue, 18 Sep 2012, Ryan Mallon wrote: On 18/09/12 15:40, Shubhrajyoti wrote: On Tuesday 18 September 2012 07:21 AM, Ryan Mallon wrote: Actually, I wonder if it is useful to have something like:. Read and write differ only in the flag also it will be a deviation from what $SUBJECT would warr

Re: [PATCH 3/7] rtc: Convert struct i2c_msg initialization to C99 format

2012-09-17 Thread Ryan Mallon
On 18/09/12 15:40, Shubhrajyoti wrote: > On Tuesday 18 September 2012 07:21 AM, Ryan Mallon wrote: >> Actually, I wonder if it is useful to have something like:. > Read and write differ only in the flag also it will be a deviation from > what $SUBJECT > would warrant. So could be a separate patch.

Re: [PATCH 3/7] rtc: Convert struct i2c_msg initialization to C99 format

2012-09-17 Thread Shubhrajyoti
On Tuesday 18 September 2012 07:21 AM, Ryan Mallon wrote: > Actually, I wonder if it is useful to have something like:. Read and write differ only in the flag also it will be a deviation from what $SUBJECT would warrant. So could be a separate patch. > > #define I2C_WRITE(_addr, _buf, _len)

Re: [PATCH 3/7] rtc: Convert struct i2c_msg initialization to C99 format

2012-09-17 Thread Shubhrajyoti
On Tuesday 18 September 2012 07:15 AM, Ryan Mallon wrote: >> , > Putting the whole initialiser on one line is a bit ugly. Any reason not > to expand it over multiple lines as the previous patch (and majority of > other drivers) does? Will do that. -- To unsubscribe from this list: sen

Re: [PATCH 3/7] rtc: Convert struct i2c_msg initialization to C99 format

2012-09-17 Thread Ryan Mallon
On 17/09/12 23:58, Shubhrajyoti D wrote: > Convert the struct i2c_msg initialization to C99 format. This makes > maintaining and editing the code simpler. Also helps once other fields > like transferred are added in future. > > Signed-off-by: Shubhrajyoti D > --- > drivers/rtc/rtc-is

Re: [PATCH 3/7] rtc: Convert struct i2c_msg initialization to C99 format

2012-09-17 Thread Ryan Mallon
On 17/09/12 23:58, Shubhrajyoti D wrote: > Convert the struct i2c_msg initialization to C99 format. This makes > maintaining and editing the code simpler. Also helps once other fields > like transferred are added in future. > > Signed-off-by: Shubhrajyoti D > --- > drivers/rtc/rtc-is