Re: [PATCH 3/5] dt-bindings: mediatek: Add smi dts binding

2015-04-14 Thread Yong Wu
Hi Mark, On Tue, 2015-04-14 at 11:06 +0100, Mark Rutland wrote: > On Tue, Apr 14, 2015 at 10:07:54AM +0100, Yong Wu wrote: > > Hi Mark, > > Thanks very much for review. > > About the clock name should be the PoV of _this_ device. Could you > > help check below? > > > > On Fri, 2015-03-06

Re: [PATCH 3/5] dt-bindings: mediatek: Add smi dts binding

2015-04-14 Thread Mark Rutland
> > > smi_common:smi@14022000 { > > > compatible = “mediate, mt8173-smi”; > > > reg = <0 0x14022000 0 0x1000>; > > > clocks = <&mmsys MM_SMI_COMMON>; > > > clocks-names = “smi_common”; > > > }; > > > > > > larb0:

Re: [PATCH 3/5] dt-bindings: mediatek: Add smi dts binding

2015-04-14 Thread Yong Wu
On Tue, 2015-04-14 at 21:49 +0800, Yong Wu wrote: > Hi Mark, > > On Tue, 2015-04-14 at 11:06 +0100, Mark Rutland wrote: > > On Tue, Apr 14, 2015 at 10:07:54AM +0100, Yong Wu wrote: > > > Hi Mark, > > > Thanks very much for review. > > > About the clock name should be the PoV of _this_ dev

Re: [PATCH 3/5] dt-bindings: mediatek: Add smi dts binding

2015-04-14 Thread Mark Rutland
On Tue, Apr 14, 2015 at 10:07:54AM +0100, Yong Wu wrote: > Hi Mark, > Thanks very much for review. > About the clock name should be the PoV of _this_ device. Could you > help check below? > > On Fri, 2015-03-06 at 11:13 +, Mark Rutland wrote: > > On Fri, Mar 06, 2015 at 10:48:18AM +00

Re: [PATCH 3/5] dt-bindings: mediatek: Add smi dts binding

2015-04-14 Thread Yong Wu
Hi Mark, Thanks very much for review. About the clock name should be the PoV of _this_ device. Could you help check below? On Fri, 2015-03-06 at 11:13 +, Mark Rutland wrote: > On Fri, Mar 06, 2015 at 10:48:18AM +, yong...@mediatek.com wrote: > > From: Yong Wu > > > > This patch

Re: [PATCH 3/5] dt-bindings: mediatek: Add smi dts binding

2015-03-09 Thread Yong Wu
Dear Mark, Thanks very much for you suggestion. On Fri, 2015-03-06 at 11:13 +, Mark Rutland wrote: > On Fri, Mar 06, 2015 at 10:48:18AM +, yong...@mediatek.com wrote: > > From: Yong Wu > > > > This patch add smi binding document. > > Please move binding documents to the start of t

Re: [PATCH 3/5] dt-bindings: mediatek: Add smi dts binding

2015-03-09 Thread Yong Wu
Dear Sergei, Thanks very much for suggestion. I will fix them in the next version. On Fri, 2015-03-06 at 17:48 +0300, Sergei Shtylyov wrote: > Hello. > > On 3/6/2015 1:48 PM, yong...@mediatek.com wrote: > > > From: Yong Wu > > > This patch add smi binding document. > > > Signe

Re: [PATCH 3/5] dt-bindings: mediatek: Add smi dts binding

2015-03-06 Thread Sergei Shtylyov
Hello. On 3/6/2015 1:48 PM, yong...@mediatek.com wrote: From: Yong Wu This patch add smi binding document. Signed-off-by: Yong Wu --- .../devicetree/bindings/soc/mediatek/mediatek,smi.txt | 17 + 1 file changed, 17 insertions(+) create mode 100644 Documentation/d

Re: [PATCH 3/5] dt-bindings: mediatek: Add smi dts binding

2015-03-06 Thread Mark Rutland
On Fri, Mar 06, 2015 at 10:48:18AM +, yong...@mediatek.com wrote: > From: Yong Wu > > This patch add smi binding document. Please move binding documents to the start of the series. It makes things far easier to review. > > Signed-off-by: Yong Wu > --- > .../devicetree/bindings/soc/mediat