Re: [PATCH 3/5] coredump: cleanup the waiting for coredump_finish code

2013-02-15 Thread Andrew Morton
On Thu, 14 Feb 2013 15:38:14 -0800 Mandeep Singh Baines wrote: > Replace the for loop with a simple if. Well OK, but why? Presumably the loop was added for a reason and presumably you believe that reason to be (no longer?) correct. Please describe all these things. > --- a/kernel/exit.c > +++

Re: [PATCH 3/5] coredump: cleanup the waiting for coredump_finish code

2013-02-15 Thread Oleg Nesterov
On 02/14, Mandeep Singh Baines wrote: > > Replace the for loop with a simple if. Why? > --- a/kernel/exit.c > +++ b/kernel/exit.c > @@ -479,12 +479,9 @@ static void exit_mm(struct task_struct * tsk) > if (atomic_dec_and_test(&core_state->nr_threads)) > complete