Re: [PATCH 3/5] clk: mediatek: Add basic clocks for Mediatek MT8135.

2015-03-17 Thread Uwe Kleine-König
Hello Sascha, On Tue, Mar 17, 2015 at 10:47:38AM +0100, Sascha Hauer wrote: > On Mon, Mar 16, 2015 at 08:03:39AM +0100, Uwe Kleine-König wrote: > > On Mon, Mar 16, 2015 at 06:55:09AM +0100, Sascha Hauer wrote: > > > +static const char *axi_parents[] __initconst = { > > > + "clk26m", > > > + "syspl

Re: [PATCH 3/5] clk: mediatek: Add basic clocks for Mediatek MT8135.

2015-03-17 Thread Sascha Hauer
On Mon, Mar 16, 2015 at 08:03:39AM +0100, Uwe Kleine-König wrote: > Hello Sascha, > > On Mon, Mar 16, 2015 at 06:55:09AM +0100, Sascha Hauer wrote: > > +static const char *axi_parents[] __initconst = { > > + "clk26m", > > + "syspll_d3", > > + "syspll_d4", > > + "syspll_d6", > > + "univpl

Re: [PATCH 3/5] clk: mediatek: Add basic clocks for Mediatek MT8135.

2015-03-16 Thread Uwe Kleine-König
Hello Sascha, On Mon, Mar 16, 2015 at 06:55:09AM +0100, Sascha Hauer wrote: > +static const char *axi_parents[] __initconst = { > + "clk26m", > + "syspll_d3", > + "syspll_d4", > + "syspll_d6", > + "univpll_d5", > + "univpll2_d2", > + "syspll_d3p5" > +}; __initconst shou

Re: [PATCH 3/5] clk: mediatek: Add basic clocks for Mediatek MT8135.

2015-03-15 Thread Sascha Hauer
On Fri, Mar 13, 2015 at 03:44:30PM +0800, Henry Chen wrote: > On Sun, 2015-02-22 at 12:49 +0100, Sascha Hauer wrote: > > +#define PLL(_id, _name, _reg, _pwr_reg, _en_mask, _flags, _pcwbits, > > _pd_reg, _pd_shift, _tuner_reg, _pcw_reg, _pcw_shift) { \ > > + .id = _id,

Re: [PATCH 3/5] clk: mediatek: Add basic clocks for Mediatek MT8135.

2015-03-15 Thread Sascha Hauer
On Mon, Mar 16, 2015 at 12:27:20AM +0800, Daniel Kurtz wrote: > Hi Sascha, > > Drive-by review... > > On Sun, Feb 22, 2015 at 7:49 PM, Sascha Hauer wrote: > > From: James Liao > > > > This patch adds basic clocks for MT8135, including TOPCKGEN, PLLs, > > INFRA and PERI clocks. > > > > Signed-of

Re: [PATCH 3/5] clk: mediatek: Add basic clocks for Mediatek MT8135.

2015-03-15 Thread Daniel Kurtz
Hi Sascha, Drive-by review... On Sun, Feb 22, 2015 at 7:49 PM, Sascha Hauer wrote: > From: James Liao > > This patch adds basic clocks for MT8135, including TOPCKGEN, PLLs, > INFRA and PERI clocks. > > Signed-off-by: James Liao > Signed-off-by: Henry Chen > Signed-off-by: Sascha Hauer > ---

Re: [PATCH 3/5] clk: mediatek: Add basic clocks for Mediatek MT8135.

2015-03-13 Thread Henry Chen
On Sun, 2015-02-22 at 12:49 +0100, Sascha Hauer wrote: > +#define PLL(_id, _name, _reg, _pwr_reg, _en_mask, _flags, _pcwbits, _pd_reg, > _pd_shift, _tuner_reg, _pcw_reg, _pcw_shift) { \ > + .id = _id, \ > + .name = _name,