Re: [PATCH 3/4] spi: s3c64xx: add gpio quirk for controller

2013-02-08 Thread Mark Brown
On Thu, Feb 07, 2013 at 10:54:01AM -0800, Girish KS wrote: > As suggested i would make two changes. > 1. would parse the "gpios" property and make decision whether to use > gpios/dedicated pins for miso/miso/clk. > 2.would parse "cs-gpio" property from dts node to handle the chip select > correc

Re: [PATCH 3/4] spi: s3c64xx: add gpio quirk for controller

2013-02-07 Thread Girish KS
On Thu, Feb 7, 2013 at 3:55 AM, Mark Brown wrote: > On Tue, Feb 05, 2013 at 03:09:43PM -0800, Girish K S wrote: >> This patch adds support for spi controllers with >> dedicated clk/miso/mosi/cs pins. It skips the gpio >> parsing and initialization for controllers that >> have dedicated pins. > >>

Re: [PATCH 3/4] spi: s3c64xx: add gpio quirk for controller

2013-02-07 Thread Mark Brown
On Tue, Feb 05, 2013 at 03:09:43PM -0800, Girish K S wrote: > This patch adds support for spi controllers with > dedicated clk/miso/mosi/cs pins. It skips the gpio > parsing and initialization for controllers that > have dedicated pins. > if (sdd->tgl_spi != spi) { /* if last mssg on

Re: [PATCH 3/4] spi: s3c64xx: add gpio quirk for controller

2013-02-06 Thread Girish KS
On Wed, Feb 6, 2013 at 2:40 AM, Grant Likely wrote: > On Tue, 5 Feb 2013 15:09:43 -0800, Girish K S wrote: >> This patch adds support for spi controllers with >> dedicated clk/miso/mosi/cs pins. It skips the gpio >> parsing and initialization for controllers that >> have dedicated pins. >> >> Si

Re: [PATCH 3/4] spi: s3c64xx: add gpio quirk for controller

2013-02-06 Thread Grant Likely
On Tue, 5 Feb 2013 15:09:43 -0800, Girish K S wrote: > This patch adds support for spi controllers with > dedicated clk/miso/mosi/cs pins. It skips the gpio > parsing and initialization for controllers that > have dedicated pins. > > Signed-off-by: Girish K S Instead of making this a quirk, yo