Re: [PATCH 3/4] rtc: rtc-jz4740: Use devm_ioremap_resource()

2014-02-07 Thread Lars-Peter Clausen
On 02/07/2014 09:31 AM, Jingoo Han wrote: On Friday, February 07, 2014 5:13 PM, Lars-Peter Clausen wrote: On 02/07/2014 08:58 AM, Jingoo Han wrote: [...] - rtc->base = devm_ioremap_nocache(&pdev->dev, rtc->mem->start, - resource_size(rtc->mem)); -

Re: [PATCH 3/4] rtc: rtc-jz4740: Use devm_ioremap_resource()

2014-02-07 Thread Jingoo Han
On Friday, February 07, 2014 5:13 PM, Lars-Peter Clausen wrote: > On 02/07/2014 08:58 AM, Jingoo Han wrote: > [...] > > - rtc->base = devm_ioremap_nocache(&pdev->dev, rtc->mem->start, > > - resource_size(rtc->mem)); > > - if (!rtc->base) { > > - dev_e

Re: [PATCH 3/4] rtc: rtc-jz4740: Use devm_ioremap_resource()

2014-02-07 Thread Lars-Peter Clausen
On 02/07/2014 08:58 AM, Jingoo Han wrote: [...] - rtc->base = devm_ioremap_nocache(&pdev->dev, rtc->mem->start, - resource_size(rtc->mem)); - if (!rtc->base) { - dev_err(&pdev->dev, "Failed to ioremap mmio memory\n"); -