Re: [PATCH 3/4] mtd: mchp23k256: add partitioning support

2017-06-08 Thread Brian Norris
On Fri, Jun 02, 2017 at 11:04:06AM +0200, Boris Brezillon wrote: > BTW, MTD_NO_ERASE is not the only problem we have with UBI or JFFS2. > Are we guaranteed that an erase operation fills an eraseblock with > ones? Don't we have mem technologies that are filling them with zeros? > Note that mtdram is

Re: [PATCH 3/4] mtd: mchp23k256: add partitioning support

2017-06-08 Thread Brian Norris
On Thu, Jun 01, 2017 at 11:08:08PM +, Chris Packham wrote: > Do we need a flag to indicate SRAM-like properties? I assume there is a > difference between NO_ERASE on ROM devices where there is just no way of > erasing the data. For {S,F,M}RAM there is no block erase operation but I think we

Re: [PATCH 3/4] mtd: mchp23k256: add partitioning support

2017-06-02 Thread Boris Brezillon
On Thu, 1 Jun 2017 15:01:56 -0700 Brian Norris wrote: > On Thu, Jun 01, 2017 at 10:47:12PM +0200, Boris Brezillon wrote: > > Le Thu, 1 Jun 2017 11:43:40 -0700, > > Brian Norris a écrit : > > > On Wed, May 17, 2017 at 05:29:11PM +0200, Boris Brezillon wrote: > > > > On Wed, 17 May 2017 17:39:

Re: [PATCH 3/4] mtd: mchp23k256: add partitioning support

2017-06-01 Thread Chris Packham
On 02/06/17 10:23, Brian Norris wrote: > On Thu, Jun 01, 2017 at 09:30:07PM +, Chris Packham wrote: >> On 02/06/17 06:43, Brian Norris wrote: >>> On Wed, May 17, 2017 at 05:29:11PM +0200, Boris Brezillon wrote: Can we fix allocate_partition() to properly handle the master->erasesize =

Re: [PATCH 3/4] mtd: mchp23k256: add partitioning support

2017-06-01 Thread Brian Norris
On Thu, Jun 01, 2017 at 09:30:07PM +, Chris Packham wrote: > On 02/06/17 06:43, Brian Norris wrote: > > On Wed, May 17, 2017 at 05:29:11PM +0200, Boris Brezillon wrote: > >> Can we fix allocate_partition() to properly handle the > >> master->erasesize == 0 case instead of doing that? > > > > Is

Re: [PATCH 3/4] mtd: mchp23k256: add partitioning support

2017-06-01 Thread Brian Norris
On Thu, Jun 01, 2017 at 10:47:12PM +0200, Boris Brezillon wrote: > Le Thu, 1 Jun 2017 11:43:40 -0700, > Brian Norris a écrit : > > On Wed, May 17, 2017 at 05:29:11PM +0200, Boris Brezillon wrote: > > > On Wed, 17 May 2017 17:39:07 +1200 > > > Chris Packham wrote: > > > > @@ -151,6 +152,10 @@ stat

Re: [PATCH 3/4] mtd: mchp23k256: add partitioning support

2017-06-01 Thread Chris Packham
On 02/06/17 06:43, Brian Norris wrote: > On Wed, May 17, 2017 at 05:29:11PM +0200, Boris Brezillon wrote: >> Hi Chris, >> >> On Wed, 17 May 2017 17:39:07 +1200 >> Chris Packham wrote: >> >>> Setting the of_node for the mtd device allows the generic mtd code to >>> setup the partitions. Additionall

Re: [PATCH 3/4] mtd: mchp23k256: add partitioning support

2017-06-01 Thread Boris Brezillon
Le Thu, 1 Jun 2017 11:43:40 -0700, Brian Norris a écrit : > On Wed, May 17, 2017 at 05:29:11PM +0200, Boris Brezillon wrote: > > Hi Chris, > > > > On Wed, 17 May 2017 17:39:07 +1200 > > Chris Packham wrote: > > > > > Setting the of_node for the mtd device allows the generic mtd code to > > >

Re: [PATCH 3/4] mtd: mchp23k256: add partitioning support

2017-06-01 Thread Brian Norris
On Wed, May 17, 2017 at 05:29:11PM +0200, Boris Brezillon wrote: > Hi Chris, > > On Wed, 17 May 2017 17:39:07 +1200 > Chris Packham wrote: > > > Setting the of_node for the mtd device allows the generic mtd code to > > setup the partitions. Additionally we must specify a non-zero erasesize > > f

Re: [PATCH 3/4] mtd: mchp23k256: add partitioning support

2017-05-22 Thread Boris Brezillon
Hi Chris, On Mon, 22 May 2017 04:52:34 + Chris Packham wrote: > On 18/05/17 03:29, Boris Brezillon wrote: > > Hi Chris, > > > > On Wed, 17 May 2017 17:39:07 +1200 > > Chris Packham wrote: > > > >> Setting the of_node for the mtd device allows the generic mtd code to > >> setup the parti

Re: [PATCH 3/4] mtd: mchp23k256: add partitioning support

2017-05-21 Thread Chris Packham
On 18/05/17 03:29, Boris Brezillon wrote: > Hi Chris, > > On Wed, 17 May 2017 17:39:07 +1200 > Chris Packham wrote: > >> Setting the of_node for the mtd device allows the generic mtd code to >> setup the partitions. Additionally we must specify a non-zero erasesize >> for the partitions to be wr

Re: [PATCH 3/4] mtd: mchp23k256: add partitioning support

2017-05-17 Thread Boris Brezillon
Hi Chris, On Wed, 17 May 2017 17:39:07 +1200 Chris Packham wrote: > Setting the of_node for the mtd device allows the generic mtd code to > setup the partitions. Additionally we must specify a non-zero erasesize > for the partitions to be writeable. > > Signed-off-by: Chris Packham > --- > dr

Re: [PATCH 3/4] mtd: mchp23k256: add partitioning support

2017-05-17 Thread Andrew Lunn
On Wed, May 17, 2017 at 05:39:07PM +1200, Chris Packham wrote: > Setting the of_node for the mtd device allows the generic mtd code to > setup the partitions. Additionally we must specify a non-zero erasesize > for the partitions to be writeable. > > Signed-off-by: Chris Packham Reviewed-by: And