Re: [PATCH 3/3] tty_io.c: don't use flush_scheduled_work()

2007-08-20 Thread Jarek Poplawski
On Thu, Aug 16, 2007 at 02:53:50PM +0300, Dan Aloni wrote: > On Sun, Jul 01, 2007 at 07:37:49PM +0400, Oleg Nesterov wrote: > > I don't know how to test this patch, the ack/nack from maintainer is wanted. > > > > flush_scheduled_work() is evil and should be avoided. Change tty_set_ldisc() > > and

Re: [PATCH 3/3] tty_io.c: don't use flush_scheduled_work()

2007-08-16 Thread Oleg Nesterov
On 08/16, Dan Aloni wrote: > > On Sun, Jul 01, 2007 at 07:37:49PM +0400, Oleg Nesterov wrote: > > I don't know how to test this patch, the ack/nack from maintainer is wanted. > > > > flush_scheduled_work() is evil and should be avoided. Change tty_set_ldisc() > > and release_dev() to use cancel_de

Re: [PATCH 3/3] tty_io.c: don't use flush_scheduled_work()

2007-08-16 Thread Dan Aloni
On Sun, Jul 01, 2007 at 07:37:49PM +0400, Oleg Nesterov wrote: > I don't know how to test this patch, the ack/nack from maintainer is wanted. > > flush_scheduled_work() is evil and should be avoided. Change tty_set_ldisc() > and release_dev() to use cancel_delayed_work_sync/cancel_work_sync. > >

Re: [PATCH 3/3] tty_io.c: don't use flush_scheduled_work()

2007-07-01 Thread Oleg Nesterov
On 07/01, Alan Cox wrote: > > On Sun, 1 Jul 2007 19:37:49 +0400 > Oleg Nesterov <[EMAIL PROTECTED]> wrote: > > > I don't know how to test this patch, the ack/nack from maintainer is wanted. > > > > flush_scheduled_work() is evil and should be avoided. Change tty_set_ldisc() > > and release_dev()

Re: [PATCH 3/3] tty_io.c: don't use flush_scheduled_work()

2007-07-01 Thread Alan Cox
On Sun, 1 Jul 2007 19:37:49 +0400 Oleg Nesterov <[EMAIL PROTECTED]> wrote: > I don't know how to test this patch, the ack/nack from maintainer is wanted. > > flush_scheduled_work() is evil and should be avoided. Change tty_set_ldisc() > and release_dev() to use cancel_delayed_work_sync/cancel_wor