Re: [PATCH 3/3] selftests: add readfile(2) selftests

2020-07-05 Thread Greg Kroah-Hartman
On Sun, Jul 05, 2020 at 01:24:07PM +0200, Geert Uytterhoeven wrote: > Hi Greg, > > On Sun, Jul 5, 2020 at 8:55 AM Greg Kroah-Hartman > wrote: > > On Sat, Jul 04, 2020 at 08:38:26PM +0200, Geert Uytterhoeven wrote: > > > On Sat, Jul 4, 2020 at 4:05 PM Greg Kroah-Hartman > > > wrote: > > > > Test

Re: [PATCH 3/3] selftests: add readfile(2) selftests

2020-07-05 Thread Geert Uytterhoeven
Hi Greg, On Sun, Jul 5, 2020 at 8:55 AM Greg Kroah-Hartman wrote: > On Sat, Jul 04, 2020 at 08:38:26PM +0200, Geert Uytterhoeven wrote: > > On Sat, Jul 4, 2020 at 4:05 PM Greg Kroah-Hartman > > wrote: > > > Test the functionality of readfile(2) in various ways. > > > > > > Also provide a simple

Re: [PATCH 3/3] selftests: add readfile(2) selftests

2020-07-05 Thread Heinrich Schuchardt
On 7/5/20 9:34 AM, Greg Kroah-Hartman wrote: > On Sun, Jul 05, 2020 at 03:41:48AM +0200, Heinrich Schuchardt wrote: >> On 7/4/20 4:02 PM, Greg Kroah-Hartman wrote: >>> Test the functionality of readfile(2) in various ways. >> >> Hello Greg, >> >> I expect readfile() to generate fanotify events FAN_

Re: [PATCH 3/3] selftests: add readfile(2) selftests

2020-07-05 Thread Greg Kroah-Hartman
On Sun, Jul 05, 2020 at 03:41:48AM +0200, Heinrich Schuchardt wrote: > On 7/4/20 4:02 PM, Greg Kroah-Hartman wrote: > > Test the functionality of readfile(2) in various ways. > > Hello Greg, > > I expect readfile() to generate fanotify events FAN_OPEN_PERM, FAN_OPEN, > FAN_ACCESS_PERM, FAN_ACCESS

Re: [PATCH 3/3] selftests: add readfile(2) selftests

2020-07-04 Thread Greg Kroah-Hartman
On Sat, Jul 04, 2020 at 08:38:26PM +0200, Geert Uytterhoeven wrote: > Hi Greg, > > On Sat, Jul 4, 2020 at 4:05 PM Greg Kroah-Hartman > wrote: > > Test the functionality of readfile(2) in various ways. > > > > Also provide a simple speed test program to benchmark using readfile() > > instead of us

Re: [PATCH 3/3] selftests: add readfile(2) selftests

2020-07-04 Thread Heinrich Schuchardt
On 7/4/20 4:02 PM, Greg Kroah-Hartman wrote: > Test the functionality of readfile(2) in various ways. Hello Greg, I expect readfile() to generate fanotify events FAN_OPEN_PERM, FAN_OPEN, FAN_ACCESS_PERM, FAN_ACCESS, FAN_CLOSE_NOWRITE in this sequence. Looking at patch 1/3 you took care of notifi

Re: [PATCH 3/3] selftests: add readfile(2) selftests

2020-07-04 Thread Geert Uytterhoeven
Hi Greg, On Sat, Jul 4, 2020 at 4:05 PM Greg Kroah-Hartman wrote: > Test the functionality of readfile(2) in various ways. > > Also provide a simple speed test program to benchmark using readfile() > instead of using open()/read()/close(). > > Signed-off-by: Greg Kroah-Hartman Any benchmark res