Re: [PATCH 3/3] rcutorture: Remove redundant assignment to cur_ops in for loop

2007-02-07 Thread Josh Triplett
Andrew Morton wrote: > On Wed, 7 Feb 2007 16:22:28 -0800 > Andrew Morton <[EMAIL PROTECTED]> wrote: >> I suspect we can do better than that... [...] Much better; please go ahead and replace my patch with this one. Signed-off-by: Josh Triplett <[EMAIL PROTECTED]> - Josh Triplett > --- a/kernel/r

Re: [PATCH 3/3] rcutorture: Remove redundant assignment to cur_ops in for loop

2007-02-07 Thread Andrew Morton
On Wed, 7 Feb 2007 16:22:28 -0800 Andrew Morton <[EMAIL PROTECTED]> wrote: > I suspect we can do better than that... err,, --- a/kernel/rcutorture.c~rcutorture-remove-redundant-assignment-to-cur_ops-in +++ a/kernel/rcutorture.c @@ -569,10 +569,6 @@ static struct rcu_torture_ops sched_ops

Re: [PATCH 3/3] rcutorture: Remove redundant assignment to cur_ops in for loop

2007-02-07 Thread Andrew Morton
On Thu, 08 Feb 2007 00:56:01 +0100 Richard Knutsson <[EMAIL PROTECTED]> wrote: > Josh Triplett wrote: > > The for loop in rcutorture_init uses the condition > > cur_ops = torture_ops[i], cur_ops > > but then makes the same assignment to cur_ops inside the loop. Remove the > > redundant assignment

Re: [PATCH 3/3] rcutorture: Remove redundant assignment to cur_ops in for loop

2007-02-07 Thread Richard Knutsson
Josh Triplett wrote: The for loop in rcutorture_init uses the condition cur_ops = torture_ops[i], cur_ops but then makes the same assignment to cur_ops inside the loop. Remove the redundant assignment inside the loop, and remove now-unnecessary braces. Signed-off-by: Josh Triplett <[EMAIL PROTE