RE: [PATCH 3/3] dma: Add Freescale eDMA engine driver support

2013-09-23 Thread Lu Jingchang-B35083
rnel.org > Subject: Re: [PATCH 3/3] dma: Add Freescale eDMA engine driver support > > On Tue, Sep 17, 2013 at 08:08:46AM +, Lu Jingchang-B35083 wrote: > > > > + case DMA_PAUSE: > > > > + if (fsl_chan->edesc) > > > > +

Re: [PATCH 3/3] dma: Add Freescale eDMA engine driver support

2013-09-22 Thread Vinod Koul
On Tue, Sep 17, 2013 at 08:08:46AM +, Lu Jingchang-B35083 wrote: > > > + case DMA_PAUSE: > > > + if (fsl_chan->edesc) > > > + fsl_edma_disable_request(fsl_chan); > > racy here too... > It only set the channel HW register, no list is handled, > is lock needed here? Thank

RE: [PATCH 3/3] dma: Add Freescale eDMA engine driver support

2013-09-17 Thread Lu Jingchang-B35083
r.kernel.org; Wang > Huan-B18965 > Subject: Re: [PATCH 3/3] dma: Add Freescale eDMA engine driver support > > + case DMA_PAUSE: > > + if (fsl_chan->edesc) > > + fsl_edma_disable_request(fsl_chan); > racy here too... It only set the channel HW re

RE: [PATCH 3/3] dma: Add Freescale eDMA engine driver support

2013-09-17 Thread Lu Jingchang-B35083
r.kernel.org; Wang > Huan-B18965 > Subject: Re: [PATCH 3/3] dma: Add Freescale eDMA engine driver support > > I need ACK from DT maintainers on the above parts Should I cc this to one of the DT maintainers? Thanks. > > > +static int fsl_edma_control(struct

Re: [PATCH 3/3] dma: Add Freescale eDMA engine driver support

2013-09-16 Thread Vinod Koul
On Thu, Sep 05, 2013 at 05:53:19PM +0800, Jingchang Lu wrote: > Add Freescale enhanced direct memory(eDMA) controller support. > The eDMA controller deploys DMAMUXs routing DMA request sources(slot) > to eDMA channels. > This module can be found on Vybrid and LS-1 SoCs. > > Signed-off-by: Alison W

Re: [PATCH 3/3] dma: Add Freescale eDMA engine driver support

2013-08-04 Thread Shawn Guo
On Fri, Aug 02, 2013 at 03:55:48PM +0800, Jingchang Lu wrote: > Add Freescale enhanced direct memory(eDMA) controller support. > The eDMA controller deploys DMAMUXs routing DMA request sources(slot) > to eDMA channels. > This module can be found on Vybrid and LS-1 SoCs. > > Signed-off-by: Alison W