Re: [PATCH 3/3] arm64/locking: qspinlocks and qrwlocks support

2017-05-09 Thread Yury Norov
On Tue, May 09, 2017 at 09:48:29PM +0300, Yury Norov wrote: > On Tue, May 09, 2017 at 12:47:08PM +0800, Boqun Feng wrote: > > On Wed, May 03, 2017 at 05:51:41PM +0300, Yury Norov wrote: > > > From: Jan Glauber > > > > > > Ported from x86_64 with paravirtualization support removed. > > > > > > Si

Re: [PATCH 3/3] arm64/locking: qspinlocks and qrwlocks support

2017-05-09 Thread Yury Norov
On Tue, May 09, 2017 at 12:47:08PM +0800, Boqun Feng wrote: > On Wed, May 03, 2017 at 05:51:41PM +0300, Yury Norov wrote: > > From: Jan Glauber > > > > Ported from x86_64 with paravirtualization support removed. > > > > Signed-off-by: Jan Glauber > > > > Note. This patch removes protection fro

Re: [PATCH 3/3] arm64/locking: qspinlocks and qrwlocks support

2017-05-08 Thread Boqun Feng
On Wed, May 03, 2017 at 05:51:41PM +0300, Yury Norov wrote: > From: Jan Glauber > > Ported from x86_64 with paravirtualization support removed. > > Signed-off-by: Jan Glauber > > Note. This patch removes protection from direct inclusion of > arch/arm64/include/asm/spinlock_types.h. It's done b

Re: [PATCH 3/3] arm64/locking: qspinlocks and qrwlocks support

2017-04-28 Thread Will Deacon
On Wed, Apr 26, 2017 at 03:39:47PM +0300, Yury Norov wrote: > On Thu, Apr 20, 2017 at 09:05:30PM +0200, Peter Zijlstra wrote: > > On Thu, Apr 20, 2017 at 09:23:18PM +0300, Yury Norov wrote: > > > Is there some test to reproduce the locking failure for the case. > > > > Possibly sysvsem stress befo

Re: [PATCH 3/3] arm64/locking: qspinlocks and qrwlocks support

2017-04-26 Thread Yury Norov
On Thu, Apr 20, 2017 at 09:05:30PM +0200, Peter Zijlstra wrote: > On Thu, Apr 20, 2017 at 09:23:18PM +0300, Yury Norov wrote: > > Is there some test to reproduce the locking failure for the case. > > Possibly sysvsem stress before commit: > > 27d7be1801a4 ("ipc/sem.c: avoid using spin_unlock_wa

Re: [PATCH 3/3] arm64/locking: qspinlocks and qrwlocks support

2017-04-20 Thread Peter Zijlstra
On Thu, Apr 20, 2017 at 09:23:18PM +0300, Yury Norov wrote: > Is there some test to reproduce the locking failure for the case. Possibly sysvsem stress before commit: 27d7be1801a4 ("ipc/sem.c: avoid using spin_unlock_wait()") Although a similar scheme is also used in nf_conntrack, see commit:

Re: [PATCH 3/3] arm64/locking: qspinlocks and qrwlocks support

2017-04-20 Thread Mark Rutland
On Thu, Apr 20, 2017 at 09:23:18PM +0300, Yury Norov wrote: > On Thu, Apr 13, 2017 at 08:12:12PM +0200, Peter Zijlstra wrote: > > On Tue, Apr 11, 2017 at 01:35:04AM +0400, Yury Norov wrote: > > > > > +++ b/arch/arm64/include/asm/qspinlock.h > > > @@ -0,0 +1,20 @@ > > > +#ifndef _ASM_ARM64_QSPINLOC

Re: [PATCH 3/3] arm64/locking: qspinlocks and qrwlocks support

2017-04-20 Thread Yury Norov
On Thu, Apr 13, 2017 at 08:12:12PM +0200, Peter Zijlstra wrote: > On Tue, Apr 11, 2017 at 01:35:04AM +0400, Yury Norov wrote: > > > +++ b/arch/arm64/include/asm/qspinlock.h > > @@ -0,0 +1,20 @@ > > +#ifndef _ASM_ARM64_QSPINLOCK_H > > +#define _ASM_ARM64_QSPINLOCK_H > > + > > +#include > > + > > +

Re: [PATCH 3/3] arm64/locking: qspinlocks and qrwlocks support

2017-04-13 Thread Peter Zijlstra
On Tue, Apr 11, 2017 at 01:35:04AM +0400, Yury Norov wrote: > +++ b/arch/arm64/include/asm/qspinlock.h > @@ -0,0 +1,20 @@ > +#ifndef _ASM_ARM64_QSPINLOCK_H > +#define _ASM_ARM64_QSPINLOCK_H > + > +#include > + > +#define queued_spin_unlock queued_spin_unlock > +/** > + * queued_spin_unlock -