Re: [PATCH 3/3] ahci: st: Add support for ST's SATA IP

2014-02-19 Thread Tejun Heo
On Wed, Feb 19, 2014 at 05:40:41PM +, Lee Jones wrote: > Have you listened to a word I've said? Or have you managed to get your > self all tangled up in what you _assumed_ was meant by the 3 words I > mentioned about fairness at the very start of this conversation? Me > thinks the latter might

Re: [PATCH 3/3] ahci: st: Add support for ST's SATA IP

2014-02-19 Thread Lee Jones
> A few more things just in case. > > On Wed, Feb 19, 2014 at 04:39:37PM +, Lee Jones wrote: > > It tells me that Hans has more spare time than I do. > > This is the crux of the problem, isn't it? The party who is creating > load should also partake in and invest resource into making the > i

Re: [PATCH 3/3] ahci: st: Add support for ST's SATA IP

2014-02-19 Thread Tejun Heo
A few more things just in case. On Wed, Feb 19, 2014 at 04:39:37PM +, Lee Jones wrote: > It tells me that Hans has more spare time than I do. This is the crux of the problem, isn't it? The party who is creating load should also partake in and invest resource into making the infrastructure fo

Re: [PATCH 3/3] ahci: st: Add support for ST's SATA IP

2014-02-19 Thread Lee Jones
> > Again, that's not what I said. It's great that your subsystem is being > > improved, but insisting that anyone who submits new code to rebase > > on top of some development patches which only exist in mail form, and > > refusing to take patches until they do so doesn't seem right to me. > > No

Re: [PATCH 3/3] ahci: st: Add support for ST's SATA IP

2014-02-19 Thread Tejun Heo
On Wed, Feb 19, 2014 at 04:39:37PM +, Lee Jones wrote: > Again, that's not what I said. It's great that your subsystem is being > improved, but insisting that anyone who submits new code to rebase > on top of some development patches which only exist in mail form, and > refusing to take patches

Re: [PATCH 3/3] ahci: st: Add support for ST's SATA IP

2014-02-19 Thread Lee Jones
> > Since when has maintaining core code been the responsibility of the > > leaf driver developers? If you're aware that the core code is > > sub-standard then it's you who should be fixing it. > > No, there isn't this clear divide between core and the leaf > developers. People working on the "co

Re: [PATCH 3/3] ahci: st: Add support for ST's SATA IP

2014-02-19 Thread Tejun Heo
On Wed, Feb 19, 2014 at 03:23:36PM +, Lee Jones wrote: > Since when has maintaining core code been the responsibility of the > leaf driver developers? If you're aware that the core code is > sub-standard then it's you who should be fixing it. No, there isn't this clear divide between core and

Re: [PATCH 3/3] ahci: st: Add support for ST's SATA IP

2014-02-19 Thread Lee Jones
> > I think that's a pretty unfair ask. I could understand if the > > patch(es) didn't apply, or were hindered by the new API change, but I > > do not believe that is the case? > > Let me make it very clear to you. If you want your code in, you help > maintaining the larger code base. I'm alread

Re: [PATCH 3/3] ahci: st: Add support for ST's SATA IP

2014-02-19 Thread Tejun Heo
Hello, Lee. On Wed, Feb 19, 2014 at 03:01:21PM +, Lee Jones wrote: > I think that's a pretty unfair ask. I could understand if the > patch(es) didn't apply, or were hindered by the new API change, but I > do not believe that is the case? Let me make it very clear to you. If you want your cod

Re: [PATCH 3/3] ahci: st: Add support for ST's SATA IP

2014-02-19 Thread Lee Jones
> > Can I do this as a subsequent patch though? The current patch fits > > neatly onto our internal stable kernel (currently v3.10). The added > > work will require back-porting Hans' patch-set, which has not yet > > reached Mainline. > > Hmm I'll apply Hans' patchset pretty soon and we still

Re: [PATCH 3/3] ahci: st: Add support for ST's SATA IP

2014-02-19 Thread Tejun Heo
Hello, Lee. On Wed, Feb 19, 2014 at 08:30:25AM +, Lee Jones wrote: > Can I do this as a subsequent patch though? The current patch fits > neatly onto our internal stable kernel (currently v3.10). The added > work will require back-porting Hans' patch-set, which has not yet > reached Mainline.

Re: [PATCH 3/3] ahci: st: Add support for ST's SATA IP

2014-02-19 Thread Lee Jones
> >> Cc: Tejun Heo > >> Cc: linux-...@vger.kernel.org > >> Signed-off-by: Lee Jones > > > > Please consider basing it on top of Hans' refactored ahci_platform. > > > > http://www.spinics.net/lists/linux-ide/msg47628.html > > Which reminds I must test the version I've rebased on top of 3.14-rc

Re: [PATCH 3/3] ahci: st: Add support for ST's SATA IP

2014-02-19 Thread Hans de Goede
Hi, On 02/19/2014 12:36 AM, Tejun Heo wrote: > On Mon, Feb 17, 2014 at 12:56:58PM +, Lee Jones wrote: >> Cc: Tejun Heo >> Cc: linux-...@vger.kernel.org >> Signed-off-by: Lee Jones > > Please consider basing it on top of Hans' refactored ahci_platform. > > http://www.spinics.net/lists/linu

Re: [PATCH 3/3] ahci: st: Add support for ST's SATA IP

2014-02-19 Thread Lee Jones
> > Cc: Tejun Heo > > Cc: linux-...@vger.kernel.org > > Signed-off-by: Lee Jones > > Please consider basing it on top of Hans' refactored ahci_platform. > > http://www.spinics.net/lists/linux-ide/msg47628.html Okay, looks reasonable. I'm happy to do the extra work. Can I do this as a subsequ

Re: [PATCH 3/3] ahci: st: Add support for ST's SATA IP

2014-02-18 Thread Tejun Heo
On Mon, Feb 17, 2014 at 12:56:58PM +, Lee Jones wrote: > Cc: Tejun Heo > Cc: linux-...@vger.kernel.org > Signed-off-by: Lee Jones Please consider basing it on top of Hans' refactored ahci_platform. http://www.spinics.net/lists/linux-ide/msg47628.html Thanks. -- tejun -- To unsubscribe f