Re: [PATCH 3/3] TTY/slave: add driver for w2sg0004 GPS

2014-12-15 Thread One Thousand Gnomes
> > Am I missing some w2sg004 specific bits here ? > > There is particular behaviour that the device is both turned on and turned > off by toggling a GPIO, and the only way to detect which state it is in is > to watch the RX uart line (by reconfiguring it as a GPIO). Ok so it is somewhat differen

Re: [PATCH 3/3] TTY/slave: add driver for w2sg0004 GPS

2014-12-12 Thread Grant Likely
On Fri, 12 Dec 2014 08:59:44 +1100 , NeilBrown wrote: > This uart-attatched GPS device has a toggle which turns > both on and off. For reliable use we need to know what > start it is in. > > So it registers with the tty for recv events when the tty > is open, and optionally configures the RX pi

Re: [PATCH 3/3] TTY/slave: add driver for w2sg0004 GPS

2014-12-11 Thread NeilBrown
On Thu, 11 Dec 2014 23:11:00 + One Thousand Gnomes wrote: > > +w2sg0004 UART-attached GPS receiver > > + > > I'm wondering why it's tied to the w2sg0004 > > > > +struct w2sg_data { > > + int gpio; > > + int irq;/* irq line from RX pin when pinctrl > > +

Re: [PATCH 3/3] TTY/slave: add driver for w2sg0004 GPS

2014-12-11 Thread One Thousand Gnomes
> +w2sg0004 UART-attached GPS receiver > + I'm wondering why it's tied to the w2sg0004 > +struct w2sg_data { > + int gpio; > + int irq;/* irq line from RX pin when pinctrl > + * set to 'idle' */ > + struct regulator *reg; > + >

Re: [PATCH 3/3] TTY/slave: add driver for w2sg0004 GPS

2014-12-11 Thread Sebastian Reichel
Hi, On Fri, Dec 12, 2014 at 08:59:44AM +1100, NeilBrown wrote: > This uart-attatched GPS device has a toggle which turns > both on and off. For reliable use we need to know what > start it is in. I guess you mean "what state it is in"? > So it registers with the tty for recv events when the tty