Re: [PATCH 3/3] KVM: Expose MSRs to userspace

2006-11-17 Thread Avi Kivity
Andrew Morton wrote: On Fri, 17 Nov 2006 09:20:49 +0200 Avi Kivity <[EMAIL PROTECTED]> wrote: +out_vcpu: + vcpu_put(vcpu); + + return rc; +} This function returns no indication of how many msrs it actually did set. Should it? It can't hurt. Is returning

Re: [PATCH 3/3] KVM: Expose MSRs to userspace

2006-11-17 Thread Andrew Morton
On Fri, 17 Nov 2006 09:20:49 +0200 Avi Kivity <[EMAIL PROTECTED]> wrote: > >> +out_vcpu: > >> + vcpu_put(vcpu); > >> + > >> + return rc; > >> +} > >> > > > > This function returns no indication of how many msrs it actually did set. > > Should it? > > > > It can't hurt. Is returning th

Re: [PATCH 3/3] KVM: Expose MSRs to userspace

2006-11-16 Thread Avi Kivity
Andrew Morton wrote: On Thu, 16 Nov 2006 18:04:22 - Avi Kivity <[EMAIL PROTECTED]> wrote: +static int kvm_dev_ioctl_set_msrs(struct kvm *kvm, struct kvm_msrs *msrs) +{ + struct kvm_vcpu *vcpu; + struct kvm_msr_entry *entry, *entries; + int rc; + u32 size, num_entr

Re: [PATCH 3/3] KVM: Expose MSRs to userspace

2006-11-16 Thread Andrew Morton
On Thu, 16 Nov 2006 18:04:22 - Avi Kivity <[EMAIL PROTECTED]> wrote: > +static int kvm_dev_ioctl_set_msrs(struct kvm *kvm, struct kvm_msrs *msrs) > +{ > + struct kvm_vcpu *vcpu; > + struct kvm_msr_entry *entry, *entries; > + int rc; > + u32 size, num_entries, i; > + > + if