Re: [PATCH 3/3] I2C: mediatek: Add driver for MediaTek I2C controller

2014-11-03 Thread Sascha Hauer
On Thu, Oct 30, 2014 at 02:16:04PM +0100, Matthias Brugger wrote: > 2014-10-29 6:37 GMT+01:00 Xudong Chen : > > +static int mt_i2c_do_transfer(struct mt_i2c *i2c) > > +{ > > + u16 addr_reg; > > + u16 control_reg; > > + int tmo = i2c->adap.timeout; > > + > > + i2c->trans_stop

Re: [PATCH 3/3] I2C: mediatek: Add driver for MediaTek I2C controller

2014-11-02 Thread xudong chen
On Fri, 2014-10-31 at 17:10 +0100, Matthias Brugger wrote: > 2014-10-31 15:38 GMT+01:00 Yingjoe Chen : > > On Fri, 2014-10-31 at 11:48 +0100, Matthias Brugger wrote: > >> 2014-10-31 7:31 GMT+01:00 xudong chen : > >> > On Thu, 2014-10-30 at 14:16 +0100, Matthias Brugger wrote: > >> >> 2014-10-29 6:3

Re: [PATCH 3/3] I2C: mediatek: Add driver for MediaTek I2C controller

2014-10-31 Thread Matthias Brugger
2014-10-31 15:38 GMT+01:00 Yingjoe Chen : > On Fri, 2014-10-31 at 11:48 +0100, Matthias Brugger wrote: >> 2014-10-31 7:31 GMT+01:00 xudong chen : >> > On Thu, 2014-10-30 at 14:16 +0100, Matthias Brugger wrote: >> >> 2014-10-29 6:37 GMT+01:00 Xudong Chen : >> >> > The mediatek SoCs have I2C controll

Re: [PATCH 3/3] I2C: mediatek: Add driver for MediaTek I2C controller

2014-10-31 Thread Yingjoe Chen
On Fri, 2014-10-31 at 11:48 +0100, Matthias Brugger wrote: > 2014-10-31 7:31 GMT+01:00 xudong chen : > > On Thu, 2014-10-30 at 14:16 +0100, Matthias Brugger wrote: > >> 2014-10-29 6:37 GMT+01:00 Xudong Chen : > >> > The mediatek SoCs have I2C controller that handle I2C transfer. > >> > This patch i

Re: [PATCH 3/3] I2C: mediatek: Add driver for MediaTek I2C controller

2014-10-31 Thread Matthias Brugger
2014-10-31 7:31 GMT+01:00 xudong chen : > On Thu, 2014-10-30 at 14:16 +0100, Matthias Brugger wrote: >> 2014-10-29 6:37 GMT+01:00 Xudong Chen : >> > The mediatek SoCs have I2C controller that handle I2C transfer. >> > This patch include common I2C bus driver. >> > This driver is compatible with I2C

Re: [PATCH 3/3] I2C: mediatek: Add driver for MediaTek I2C controller

2014-10-30 Thread xudong chen
On Thu, 2014-10-30 at 14:16 +0100, Matthias Brugger wrote: > 2014-10-29 6:37 GMT+01:00 Xudong Chen : > > The mediatek SoCs have I2C controller that handle I2C transfer. > > This patch include common I2C bus driver. > > This driver is compatible with I2C controller on mt65xx/mt81xx. > > > > Signed-o

Re: [PATCH 3/3] I2C: mediatek: Add driver for MediaTek I2C controller

2014-10-30 Thread Yingjoe Chen
On Thu, 2014-10-30 at 14:25 +0100, Wolfram Sang wrote: > > > +obj-$(CONFIG_I2C_MT65XX) += i2c-mt65xx.o > > > > As it works for mt65xx and mt81xx series, better rename it to i2c-mtk.c > > That is a bit too generic IMO. It is likely that we will see some > totally different I2C core from MTK

Re: [PATCH 3/3] I2C: mediatek: Add driver for MediaTek I2C controller

2014-10-30 Thread Wolfram Sang
> > +obj-$(CONFIG_I2C_MT65XX) += i2c-mt65xx.o > > As it works for mt65xx and mt81xx series, better rename it to i2c-mtk.c That is a bit too generic IMO. It is likely that we will see some totally different I2C core from MTK in the future. Plus, it is not uncommon that a driver initially for

Re: [PATCH 3/3] I2C: mediatek: Add driver for MediaTek I2C controller

2014-10-30 Thread Matthias Brugger
2014-10-29 6:37 GMT+01:00 Xudong Chen : > The mediatek SoCs have I2C controller that handle I2C transfer. > This patch include common I2C bus driver. > This driver is compatible with I2C controller on mt65xx/mt81xx. > > Signed-off-by: Xudong Chen > Change-Id: Icc17e326b9df46a226d536956e103f17b0382