Re: [PATCH 27/74] lto: Mark EXPORT_SYMBOL symbols __visible

2012-08-20 Thread Andi Kleen
> Really, why? Seems like a win to have them eliminated if unused. > > Naively, I would think many cases of __visible should be #ifdef > CONFIG_MODULES. What am I missing? It worked around some problem I forgot now :) You're right it shouldn't be needed in theory for !MODULES. I'll double chec

Re: [PATCH 27/74] lto: Mark EXPORT_SYMBOL symbols __visible

2012-08-20 Thread Rusty Russell
On Sat, 18 Aug 2012 19:56:23 -0700, Andi Kleen wrote: > @@ -78,11 +78,13 @@ extern struct module __this_module; > > #else /* !CONFIG_MODULES... */ > > -#define EXPORT_SYMBOL(sym) > -#define EXPORT_SYMBOL_GPL(sym) > -#define EXPORT_SYMBOL_GPL_FUTURE(sym) > -#define EXPORT_UNUSED_SYMBOL(sym) >