Re: [PATCH 27/32] gpio: Add support for the FXL6408 GPIO expander.

2016-06-09 Thread Eric Anholt
Linus Walleij writes: > On Wed, Jun 1, 2016 at 11:43 PM, Gerd Hoffmann wrote: > >> +#define FXL6408_OUTPUT 0x05 >> +/* Bits here make the output High-Z, instead of the OUTPUT value. */ >> +#define FXL6408_OUTPUT_HIGH_Z 0x07 > (...) >> + /* Disable High-Z of outputs

Re: [PATCH 27/32] gpio: Add support for the FXL6408 GPIO expander.

2016-06-08 Thread Linus Walleij
On Wed, Jun 1, 2016 at 11:43 PM, Gerd Hoffmann wrote: > +#define FXL6408_OUTPUT 0x05 > +/* Bits here make the output High-Z, instead of the OUTPUT value. */ > +#define FXL6408_OUTPUT_HIGH_Z 0x07 (...) > + /* Disable High-Z of outputs, so that our OUTPUT updates > +

Re: [PATCH 27/32] gpio: Add support for the FXL6408 GPIO expander.

2016-06-06 Thread Florian Fainelli
On 06/01/2016 02:43 PM, Gerd Hoffmann wrote: > From: Eric Anholt > > This commit needs to be split up and cleaned up. Also we should add > interrupt support before pushing upstream. > > Signed-off-by: Eric Anholt > > Conflicts: > arch/arm64/boot/dts/broadcom/bcm2837-rpi-3-b.dts > --- >

Re: [PATCH 27/32] gpio: Add support for the FXL6408 GPIO expander.

2016-06-06 Thread Eric Anholt
Gerd Hoffmann writes: > From: Eric Anholt > > This commit needs to be split up and cleaned up. Also we should add > interrupt support before pushing upstream. > > Signed-off-by: Eric Anholt OK, I've confirmed with the firmware maintainers: We really can't drive this natively from Linux. The