Re: [PATCH 23/23] clocksource tsc: add verify routine

2007-01-31 Thread Ingo Molnar
* Daniel Walker <[EMAIL PROTECTED]> wrote: > > firstly, it allows a circular verification dependency in > > highres+dyntick mode between the jiffies and tsc clocksources. > > In the current implementation, it's only happens if the only clocks > that exist are "tsc" and "jiffies" which makes ve

Re: [PATCH 23/23] clocksource tsc: add verify routine

2007-01-31 Thread Thomas Gleixner
On Wed, 2007-01-31 at 09:02 -0800, Daniel Walker wrote: > > well, this implementation is buggy in at least two ways: > > > > firstly, it allows a circular verification dependency in highres+dyntick > > mode between the jiffies and tsc clocksources. > > In the current implementation, it's only ha

Re: [PATCH 23/23] clocksource tsc: add verify routine

2007-01-31 Thread Daniel Walker
On Wed, 2007-01-31 at 13:43 +0100, Ingo Molnar wrote: > * Daniel Walker <[EMAIL PROTECTED]> wrote: > > > I've included this as another user of the clocksource interface. I > > don't see a usage for this across all achitectures. So a fully generic > > version isn't needed. > > well, this impleme

Re: [PATCH 23/23] clocksource tsc: add verify routine

2007-01-31 Thread Ingo Molnar
* Daniel Walker <[EMAIL PROTECTED]> wrote: > I've included this as another user of the clocksource interface. I > don't see a usage for this across all achitectures. So a fully generic > version isn't needed. well, this implementation is buggy in at least two ways: firstly, it allows a circul