Re: [PATCH 22/22] parisc: use generic dma_noncoherent_ops

2018-04-25 Thread Helge Deller
On 25.04.2018 09:21, Christoph Hellwig wrote: > On Sat, Apr 21, 2018 at 07:43:46PM +0200, Helge Deller wrote: >> This patch breaks a 32bit kernel on a B160L machine (PA7300LC CPU, "pcxl2"). >> After applying this patch series the lasi82956 network driver works >> unreliable. >> NIC gets IP, but p

Re: [PATCH 22/22] parisc: use generic dma_noncoherent_ops

2018-04-25 Thread Christoph Hellwig
On Sat, Apr 21, 2018 at 07:43:46PM +0200, Helge Deller wrote: > This patch breaks a 32bit kernel on a B160L machine (PA7300LC CPU, "pcxl2"). > After applying this patch series the lasi82956 network driver works > unreliable. > NIC gets IP, but ping doesn't work. > See drivers/net/ethernet/i825xx/

Re: [PATCH 22/22] parisc: use generic dma_noncoherent_ops

2018-04-24 Thread Christoph Hellwig
On Sat, Apr 21, 2018 at 10:42:47PM +0100, James Bottomley wrote: > Well, this is wrong: you just made every 32 bit parisc system > unnecessarily use non-coherent. We actually only have a small small > set of non-coherent systems. The pxcs and pcxt systems (which are > about 99% of the user base)

Re: [PATCH 22/22] parisc: use generic dma_noncoherent_ops

2018-04-21 Thread James Bottomley
On Sat, 2018-04-21 at 19:43 +0200, Helge Deller wrote: > On 20.04.2018 10:03, Christoph Hellwig wrote: > > Switch to the generic noncoherent direct mapping implementation. > > > > Parisc previously had two different non-coherent dma ops > > implementation that just different in the way coherent al

Re: [PATCH 22/22] parisc: use generic dma_noncoherent_ops

2018-04-21 Thread James Bottomley
On Fri, 2018-04-20 at 10:03 +0200, Christoph Hellwig wrote: > diff --git a/arch/parisc/kernel/setup.c b/arch/parisc/kernel/setup.c > index 8d3a7b80ac42..4e87c35c22b7 100644 > --- a/arch/parisc/kernel/setup.c > +++ b/arch/parisc/kernel/setup.c > @@ -97,14 +97,12 @@ void __init dma_ops_init(void) >  

Re: [PATCH 22/22] parisc: use generic dma_noncoherent_ops

2018-04-21 Thread Helge Deller
On 20.04.2018 10:03, Christoph Hellwig wrote: > Switch to the generic noncoherent direct mapping implementation. > > Parisc previously had two different non-coherent dma ops implementation > that just different in the way coherent allocations were handled or not > handled. The different behavior