Re: [PATCH 2.6.13] libata: use common pci remove in ahci

2005-09-06 Thread Jeff Garzik
Brett Russ wrote: Jeff Garzik wrote: Brett Russ wrote: 2) Isn't it wrong for the IRQ disable at the chip to occur *after* free_irq() is called to disconnect the handler (independent of question 1...since this is the case currently)? Granted, all of the ports have gone through scsi_remove_host(

Re: [PATCH 2.6.13] libata: use common pci remove in ahci

2005-09-06 Thread Brett Russ
Jeff Garzik wrote: Brett Russ wrote: 2) Isn't it wrong for the IRQ disable at the chip to occur *after* free_irq() is called to disconnect the handler (independent of question 1...since this is the case currently)? Granted, all of the ports have gone through scsi_remove_host() but theoretically

Re: [PATCH 2.6.13] libata: use common pci remove in ahci

2005-09-05 Thread Jeff Garzik
Brett Russ wrote: Jeff, This looked prime to cut since ahci_remove_one() was a functionally identical to ata_pci_remove_one() except for the interrupt disable (have_msi) bits, which fit nicely into ahci_host_stop(). However, 1) Will it work? 2) Isn't it wrong for the IRQ disable at the chip t