Re: [PATCH 2.6.11.2 1/1] PCI Allow OutOfRange PIRQ table address

2005-03-16 Thread Randy.Dunlap
[EMAIL PROTECTED] wrote: Hi Greg, PCI folk, I updated this to change pirq_table_addr to a long, and to add a warning msg if the PIRQ table wasn't found at the specified address, as per thread with Matthew Wilcox. Let me know if it's okay. Thanks. In our hardware situation, the BIOS is unable to sto

Re: [PATCH 2.6.11.2 1/1] PCI Allow OutOfRange PIRQ table address

2005-03-11 Thread jayalk
On Thu, 10 Mar 2005, Matthew Wilcox wrote: +extern unsigned int pirq_table_addr; Completely nitpicking, but I think this should be an unsigned long rather than an int -- physical addresses are normally expressed in terms of unsigned long. Yup, good point, I'll fix that. Should we fall back to searc

Re: [PATCH 2.6.11.2 1/1] PCI Allow OutOfRange PIRQ table address

2005-03-10 Thread Matthew Wilcox
On Thu, Mar 10, 2005 at 05:29:35AM -0800, [EMAIL PROTECTED] wrote: Nice work, I like it. You could make it even prettier: > diff -uprN -X dontdiff linux-2.6.11.2-vanilla/arch/i386/pci/irq.c > linux-2.6.11.2/arch/i386/pci/irq.c > --- linux-2.6.11.2-vanilla/arch/i386/pci/irq.c2005-03-10