Re: [PATCH 2/7] atm: replace del_timer by del_timer_sync

2014-03-27 Thread David Miller
From: Julia Lawall Date: Wed, 26 Mar 2014 22:33:40 +0100 > From: Julia Lawall > > Use del_timer_sync to ensure that the timer is stopped on all CPUs before > the driver exists. > > This change was suggested by Thomas Gleixner. > > The semantic patch that makes this change is as follows: > (ht

Re: [PATCH 2/7] atm: replace del_timer by del_timer_sync

2014-03-26 Thread Thomas Gleixner
On Wed, 26 Mar 2014, Eric Dumazet wrote: > On Wed, 2014-03-26 at 23:02 +0100, Thomas Gleixner wrote: > > > That's why you need del_timer_sync() it waits for the timer handler to > > complete and then removes it. > > Interesting... So maybe some comment is stale ? > > > diff --git a/kernel/ti

Re: [PATCH 2/7] atm: replace del_timer by del_timer_sync

2014-03-26 Thread Eric Dumazet
On Wed, 2014-03-26 at 15:19 -0700, Vijay Subramanian wrote: > > > > It seems this timer rearms itself, so this patch wont be enough I fear. > > > > > > > Does that matter? It seems del_timer_sync() may be intended to work > despite this (i.e. timer will not fire after call to this function). > My e

Re: [PATCH 2/7] atm: replace del_timer by del_timer_sync

2014-03-26 Thread Eric Dumazet
On Wed, 2014-03-26 at 23:02 +0100, Thomas Gleixner wrote: > That's why you need del_timer_sync() it waits for the timer handler to > complete and then removes it. Interesting... So maybe some comment is stale ? diff --git a/kernel/timer.c b/kernel/timer.c index accfd241b9e5..c948fa2fc065 100644

Re: [PATCH 2/7] atm: replace del_timer by del_timer_sync

2014-03-26 Thread Vijay Subramanian
> > It seems this timer rearms itself, so this patch wont be enough I fear. > > > Does that matter? It seems del_timer_sync() may be intended to work despite this (i.e. timer will not fire after call to this function). My earlier attempt to fix a similar issue in sch_red.c resulted in this explanat

Re: [PATCH 2/7] atm: replace del_timer by del_timer_sync

2014-03-26 Thread Thomas Gleixner
On Wed, 26 Mar 2014, Eric Dumazet wrote: > On Wed, 2014-03-26 at 22:33 +0100, Julia Lawall wrote: > > From: Julia Lawall > > > > > diff --git a/net/atm/mpc.c b/net/atm/mpc.c > > index b71ff6b..91dc58f 100644 > > --- a/net/atm/mpc.c > > +++ b/net/atm/mpc.c > > @@ -1492,7 +1492,7 @@ static void __

Re: [PATCH 2/7] atm: replace del_timer by del_timer_sync

2014-03-26 Thread Eric Dumazet
On Wed, 2014-03-26 at 22:33 +0100, Julia Lawall wrote: > From: Julia Lawall > > diff --git a/net/atm/mpc.c b/net/atm/mpc.c > index b71ff6b..91dc58f 100644 > --- a/net/atm/mpc.c > +++ b/net/atm/mpc.c > @@ -1492,7 +1492,7 @@ static void __exit atm_mpoa_cleanup(void) > > mpc_proc_clean(); >