Re: [PATCH 2/6] firewire: isochronous and asynchronous I/O

2007-05-03 Thread Stefan Richter
Kristian Høgsberg wrote: > Christoph Hellwig wrote: [...] >>> + retval = fw_core_add_descriptor(&model_id_descriptor); >>> + BUG_ON(retval < 0); >> >> These kinds of bug checks look wrong. Either the operations >> can't fail in which case they should not return an error value >> or you should

Re: [PATCH 2/6] firewire: isochronous and asynchronous I/O

2007-05-02 Thread Kristian Høgsberg
Christoph Hellwig wrote: + for (i = 0; i < buffer->page_count; i++) { + buffer->pages[i] = alloc_page(GFP_KERNEL | GFP_DMA32 | __GFP_ZERO); + if (buffer->pages[i] == NULL) + goto out_pages; + + address = dma_map_page(card->dev

Re: [PATCH 2/6] firewire: isochronous and asynchronous I/O

2007-05-02 Thread Christoph Hellwig
> + for (i = 0; i < buffer->page_count; i++) { > + buffer->pages[i] = alloc_page(GFP_KERNEL | GFP_DMA32 | > __GFP_ZERO); > + if (buffer->pages[i] == NULL) > + goto out_pages; > + > + address = dma_map_page(card->device, buffer->pages[i],