Re: [PATCH 2/5] leds: core: Add LED_BLINK_CHANGE and LED_BLINK_DISABLE flags

2015-10-06 Thread Pavel Machek
On Wed 2015-09-16 12:47:41, Jacek Anaszewski wrote: > This patch adds LED_BLINK_CHANGE flag to indicate that blink brightness > has changed, and LED_BLINK_DISABLE flag to indicate that blinking > deactivation has been requested. In order to use the flags > led_timer_function and set_brightness_del

Re: [PATCH 2/5] leds: core: Add LED_BLINK_CHANGE and LED_BLINK_DISABLE flags

2015-09-23 Thread Jacek Anaszewski
Hi Andrew, Thanks for the review. On 09/22/2015 08:44 PM, Andrew Lunn wrote: On Wed, Sep 16, 2015 at 12:47:41PM +0200, Jacek Anaszewski wrote: This patch adds LED_BLINK_CHANGE flag to indicate that blink brightness has changed Hi Jacek The name LED_BLINK_CHANGE does not make me think of cha

Re: [PATCH 2/5] leds: core: Add LED_BLINK_CHANGE and LED_BLINK_DISABLE flags

2015-09-22 Thread Andrew Lunn
On Wed, Sep 16, 2015 at 12:47:41PM +0200, Jacek Anaszewski wrote: > This patch adds LED_BLINK_CHANGE flag to indicate that blink brightness > has changed Hi Jacek The name LED_BLINK_CHANGE does not make me think of changing brightness. Maybe a better name would be LED_BLINK_BRIGHTNESS_CHANGE, alt