Re: [PATCH 2/5] dmaengine: Add support for custom data mapping

2017-04-07 Thread Abhishek Sahu
On 2017-01-20 22:26, Vinod Koul wrote: On Thu, Jan 19, 2017 at 08:13:17AM -0600, Andy Gross wrote: On Thu, Jan 19, 2017 at 10:31:50AM +0530, Vinod Koul wrote: > This makes it bam specific and causes issues if we want to use this code in > generic libs, but yes this is an option but should be

Re: [PATCH 2/5] dmaengine: Add support for custom data mapping

2017-01-20 Thread Vinod Koul
On Thu, Jan 19, 2017 at 08:13:17AM -0600, Andy Gross wrote: > On Thu, Jan 19, 2017 at 10:31:50AM +0530, Vinod Koul wrote: > > > > > > > > > > > > >I really think that we need some additional API that allows for the > > > > >flag > > > > >munging > > > > >for the descriptors instead of overridin

Re: [PATCH 2/5] dmaengine: Add support for custom data mapping

2017-01-19 Thread Abhishek Sahu
On 2017-01-19 19:43, Andy Gross wrote: On Thu, Jan 19, 2017 at 10:31:50AM +0530, Vinod Koul wrote: > > > > > >I really think that we need some additional API that allows for the flag > > >munging > > >for the descriptors instead of overriding the prep_slave_sg. We already > > >needed > > >to

Re: [PATCH 2/5] dmaengine: Add support for custom data mapping

2017-01-19 Thread Andy Gross
On Thu, Jan 19, 2017 at 10:31:50AM +0530, Vinod Koul wrote: > > > > > > > >I really think that we need some additional API that allows for the flag > > > >munging > > > >for the descriptors instead of overriding the prep_slave_sg. We already > > > >needed > > > >to change the way the flags are

Re: [PATCH 2/5] dmaengine: Add support for custom data mapping

2017-01-18 Thread Vinod Koul
On Mon, Jan 02, 2017 at 10:12:33AM -0600, Andy Gross wrote: > On Mon, Jan 02, 2017 at 07:55:37PM +0530, Abhishek Sahu wrote: > > >>> So a couple of thoughts on how to deal with this: > > >>> > > >>> 1) Define a virtual channel for the command descriptors vs a normal > > >>> DMA > >

Re: [PATCH 2/5] dmaengine: Add support for custom data mapping

2017-01-02 Thread Andy Gross
On Mon, Jan 02, 2017 at 07:55:37PM +0530, Abhishek Sahu wrote: > On 2016-12-29 23:24, Andy Gross wrote: > >On Thu, Dec 22, 2016 at 01:04:37AM +0530, Abhishek Sahu wrote: > >>On 2016-12-21 01:55, Andy Gross wrote: > >>>On Wed, Dec 21, 2016 at 12:58:50AM +0530, Abhishek Sahu wrote: > >>> > >>> > >>>

Re: [PATCH 2/5] dmaengine: Add support for custom data mapping

2017-01-02 Thread Abhishek Sahu
On 2016-12-29 23:24, Andy Gross wrote: On Thu, Dec 22, 2016 at 01:04:37AM +0530, Abhishek Sahu wrote: On 2016-12-21 01:55, Andy Gross wrote: >On Wed, Dec 21, 2016 at 12:58:50AM +0530, Abhishek Sahu wrote: > > > Okay, do you have pointer on that one, will avoid asking the same questions >

Re: [PATCH 2/5] dmaengine: Add support for custom data mapping

2016-12-29 Thread Andy Gross
On Thu, Dec 22, 2016 at 01:04:37AM +0530, Abhishek Sahu wrote: > On 2016-12-21 01:55, Andy Gross wrote: > >On Wed, Dec 21, 2016 at 12:58:50AM +0530, Abhishek Sahu wrote: > > > > > > > Okay, do you have pointer on that one, will avoid asking the same > questions > again. > >>> > >>>I'll

Re: [PATCH 2/5] dmaengine: Add support for custom data mapping

2016-12-21 Thread Abhishek Sahu
On 2016-12-21 01:55, Andy Gross wrote: On Wed, Dec 21, 2016 at 12:58:50AM +0530, Abhishek Sahu wrote: >>Okay, do you have pointer on that one, will avoid asking the same >>questions >>again. > >I'll see if I can find the correspondance and send to you directly. > >> >>> Ahbishek, correct me w

Re: [PATCH 2/5] dmaengine: Add support for custom data mapping

2016-12-20 Thread Andy Gross
On Wed, Dec 21, 2016 at 12:58:50AM +0530, Abhishek Sahu wrote: > >>Okay, do you have pointer on that one, will avoid asking the same > >>questions > >>again. > > > >I'll see if I can find the correspondance and send to you directly. > > > >> > >>> Ahbishek, correct me where i am wrong on the fol

Re: [PATCH 2/5] dmaengine: Add support for custom data mapping

2016-12-20 Thread Abhishek Sahu
On 2016-12-19 23:22, Andy Gross wrote: On Mon, Dec 19, 2016 at 09:19:23PM +0530, Vinod Koul wrote: On Sun, Dec 18, 2016 at 11:06:42PM -0600, Andy Gross wrote: > On Sun, Dec 18, 2016 at 09:56:02PM +0530, Vinod Koul wrote: > > On Thu, Dec 15, 2016 at 03:25:52PM +0530, Abhishek Sahu wrote: > > > Th

Re: [PATCH 2/5] dmaengine: Add support for custom data mapping

2016-12-19 Thread Andy Gross
On Mon, Dec 19, 2016 at 09:19:23PM +0530, Vinod Koul wrote: > On Sun, Dec 18, 2016 at 11:06:42PM -0600, Andy Gross wrote: > > On Sun, Dec 18, 2016 at 09:56:02PM +0530, Vinod Koul wrote: > > > On Thu, Dec 15, 2016 at 03:25:52PM +0530, Abhishek Sahu wrote: > > > > The current DMA APIs only support SG

Re: [PATCH 2/5] dmaengine: Add support for custom data mapping

2016-12-19 Thread Vinod Koul
On Sun, Dec 18, 2016 at 11:06:42PM -0600, Andy Gross wrote: > On Sun, Dec 18, 2016 at 09:56:02PM +0530, Vinod Koul wrote: > > On Thu, Dec 15, 2016 at 03:25:52PM +0530, Abhishek Sahu wrote: > > > The current DMA APIs only support SGL or data in generic format. > > > The QCA BAM DMA engine data canno

Re: [PATCH 2/5] dmaengine: Add support for custom data mapping

2016-12-18 Thread Andy Gross
On Sun, Dec 18, 2016 at 09:56:02PM +0530, Vinod Koul wrote: > On Thu, Dec 15, 2016 at 03:25:52PM +0530, Abhishek Sahu wrote: > > The current DMA APIs only support SGL or data in generic format. > > The QCA BAM DMA engine data cannot be mapped with already > > available APIs due to following reasons

Re: [PATCH 2/5] dmaengine: Add support for custom data mapping

2016-12-18 Thread Vinod Koul
On Thu, Dec 15, 2016 at 03:25:52PM +0530, Abhishek Sahu wrote: > The current DMA APIs only support SGL or data in generic format. > The QCA BAM DMA engine data cannot be mapped with already > available APIs due to following reasons. > > 1. The QCA BAM DMA engine uses custom flags which cannot be >