Re: [PATCH 2/4] gpiolib: use const parameters when possible

2014-11-25 Thread Janusz Użycki
Hello, W dniu 2014-11-25 o 08:37, Alexandre Courbot pisze: On Wed, Nov 19, 2014 at 7:09 PM, Uwe Kleine-König wrote: Hello Alexandre, On Wed, Nov 19, 2014 at 06:07:50PM +0900, Alexandre Courbot wrote: On Wed, Nov 19, 2014 at 6:02 PM, Uwe Kleine-König wrote: I'd make gpiod_get_direction st

Re: [PATCH 2/4] gpiolib: use const parameters when possible

2014-11-24 Thread Alexandre Courbot
On Wed, Nov 19, 2014 at 7:09 PM, Uwe Kleine-König wrote: > Hello Alexandre, > > On Wed, Nov 19, 2014 at 06:07:50PM +0900, Alexandre Courbot wrote: >> On Wed, Nov 19, 2014 at 6:02 PM, Uwe Kleine-König >> wrote: >> > I'd make gpiod_get_direction static and only use it to fill in >> > /sys/kernel/d

Re: [PATCH 2/4] gpiolib: use const parameters when possible

2014-11-19 Thread Uwe Kleine-König
Hello Alexandre, On Wed, Nov 19, 2014 at 06:07:50PM +0900, Alexandre Courbot wrote: > On Wed, Nov 19, 2014 at 6:02 PM, Uwe Kleine-König > wrote: > > I'd make gpiod_get_direction static and only use it to fill in > > /sys/kernel/debug/gpio. > > That's very tempting. I see only atmel_serial.c usi

Re: [PATCH 2/4] gpiolib: use const parameters when possible

2014-11-19 Thread Alexandre Courbot
On Wed, Nov 19, 2014 at 6:02 PM, Uwe Kleine-König wrote: > Hello Alexandre, > > On Wed, Nov 19, 2014 at 05:57:46PM +0900, Alexandre Courbot wrote: >> On Wed, Nov 19, 2014 at 5:44 PM, Uwe Kleine-König >> wrote: >> > Hello Alexandre, >> > >> > On Wed, Nov 19, 2014 at 05:33:42PM +0900, Alexandre Co

Re: [PATCH 2/4] gpiolib: use const parameters when possible

2014-11-19 Thread Uwe Kleine-König
Hello Alexandre, On Wed, Nov 19, 2014 at 05:57:46PM +0900, Alexandre Courbot wrote: > On Wed, Nov 19, 2014 at 5:44 PM, Uwe Kleine-König > wrote: > > Hello Alexandre, > > > > On Wed, Nov 19, 2014 at 05:33:42PM +0900, Alexandre Courbot wrote: > >> On Mon, Nov 17, 2014 at 6:09 PM, Uwe Kleine-König >

Re: [PATCH 2/4] gpiolib: use const parameters when possible

2014-11-19 Thread Alexandre Courbot
On Wed, Nov 19, 2014 at 5:44 PM, Uwe Kleine-König wrote: > Hello Alexandre, > > On Wed, Nov 19, 2014 at 05:33:42PM +0900, Alexandre Courbot wrote: >> On Mon, Nov 17, 2014 at 6:09 PM, Uwe Kleine-König >> wrote: >> > Hello, >> > >> > On Wed, Feb 13, 2013 at 04:03:00PM +0900, Alexandre Courbot wrote

Re: [PATCH 2/4] gpiolib: use const parameters when possible

2014-11-19 Thread Uwe Kleine-König
Hello Alexandre, On Wed, Nov 19, 2014 at 05:33:42PM +0900, Alexandre Courbot wrote: > On Mon, Nov 17, 2014 at 6:09 PM, Uwe Kleine-König > wrote: > > Hello, > > > > On Wed, Feb 13, 2013 at 04:03:00PM +0900, Alexandre Courbot wrote: > >> From: Alexandre Courbot > >> > >> Constify descriptor parame

Re: [PATCH 2/4] gpiolib: use const parameters when possible

2014-11-19 Thread Alexandre Courbot
On Mon, Nov 17, 2014 at 6:09 PM, Uwe Kleine-König wrote: > Hello, > > On Wed, Feb 13, 2013 at 04:03:00PM +0900, Alexandre Courbot wrote: >> From: Alexandre Courbot >> >> Constify descriptor parameter of gpiod_* functions for those that >> should obviously not modify it. This includes value or dir

Re: [PATCH 2/4] gpiolib: use const parameters when possible

2014-11-17 Thread Uwe Kleine-König
Hello, On Wed, Feb 13, 2013 at 04:03:00PM +0900, Alexandre Courbot wrote: > From: Alexandre Courbot > > Constify descriptor parameter of gpiod_* functions for those that > should obviously not modify it. This includes value or direction get, > cansleep, and IRQ number query. > > Signed-off-by:

Re: [PATCH 2/4] gpiolib: use const parameters when possible

2013-02-26 Thread Grant Likely
On Fri, 15 Feb 2013 14:46:15 +0900, Alexandre Courbot wrote: > Constify descriptor parameter of gpiod_* functions for those that > should obviously not modify it. This includes value or direction get, > cansleep, and IRQ number query. > > Signed-off-by: Alexandre Courbot Applied, thanks. g.