Re: [PATCH 2/4] aio: use the macro rather than the inline magic number

Hi Lei, On 07/25/2014 11:13 AM, Ming Lei wrote: > On Tue, Jul 22, 2014 at 9:54 PM, Jeff Moyer wrote: >> Gu Zheng writes: >> >>> Signed-off-by: Gu Zheng >> >> Reviewed-by: Jeff Moyer >> >>> --- >>> fs/aio.c |2 +- >>> 1 files changed, 1 insertions(+), 1 deletions(-) >>> >>> diff --git a/fs

Re: [PATCH 2/4] aio: use the macro rather than the inline magic number

On Tue, Jul 22, 2014 at 9:54 PM, Jeff Moyer wrote: > Gu Zheng writes: > >> Signed-off-by: Gu Zheng > > Reviewed-by: Jeff Moyer > >> --- >> fs/aio.c |2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/fs/aio.c b/fs/aio.c >> index ad35876..1dc6158 100644 >> --- a/fs

Re: [PATCH 2/4] aio: use the macro rather than the inline magic number

On Tue, Jul 22, 2014 at 10:40:02AM +0800, Gu Zheng wrote: > Signed-off-by: Gu Zheng You're missing a commit message here. The patch is otherwise fine. -ben > --- > fs/aio.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/fs/aio.c b/fs/aio.c > in

Re: [PATCH 2/4] aio: use the macro rather than the inline magic number

Gu Zheng writes: > Signed-off-by: Gu Zheng Reviewed-by: Jeff Moyer > --- > fs/aio.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/fs/aio.c b/fs/aio.c > index ad35876..1dc6158 100644 > --- a/fs/aio.c > +++ b/fs/aio.c > @@ -201,7 +201,7 @@ static struct dentry