Re: [PATCH 2/3] sched: trivial sparse warning in sched.c

2008-02-17 Thread Cyrill Gorcunov
[Peter Zijlstra - Sat, Feb 16, 2008 at 10:45:14PM +0100] | | On Sun, 2008-02-17 at 00:27 +0300, Cyrill Gorcunov wrote: | > [Peter Zijlstra - Sat, Feb 16, 2008 at 10:11:29PM +0100] | > | [...] | > | > Hi Peter, | > | > dont you find 'return (void)foo();' statement a bit strange (as it was in | >

Re: [PATCH 2/3] sched: trivial sparse warning in sched.c

2008-02-16 Thread Peter Zijlstra
On Sun, 2008-02-17 at 00:27 +0300, Cyrill Gorcunov wrote: > [Peter Zijlstra - Sat, Feb 16, 2008 at 10:11:29PM +0100] > | > | On Fri, 2008-02-15 at 09:56 -0800, Harvey Harrison wrote: > | > kernel/sched.c:3680:3: warning: returning void-valued expression > | > | I'm wondering,... why is this wron

Re: [PATCH 2/3] sched: trivial sparse warning in sched.c

2008-02-16 Thread Cyrill Gorcunov
[Peter Zijlstra - Sat, Feb 16, 2008 at 10:11:29PM +0100] | | On Fri, 2008-02-15 at 09:56 -0800, Harvey Harrison wrote: | > kernel/sched.c:3680:3: warning: returning void-valued expression | | I'm wondering,... why is this wrong? | | > Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> | > --- |

Re: [PATCH 2/3] sched: trivial sparse warning in sched.c

2008-02-16 Thread Peter Zijlstra
On Fri, 2008-02-15 at 09:56 -0800, Harvey Harrison wrote: > kernel/sched.c:3680:3: warning: returning void-valued expression I'm wondering,... why is this wrong? > Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> > --- > kernel/sched.c |6 -- > 1 files changed, 4 insertions(+), 2 dele