Re: [PATCH 2/3] reset: mchp: sparx5: add switch reset driver

2021-01-14 Thread Steen Hegelund
Hi Philipp, On Thu, 2021-01-14 at 10:39 +0100, Philipp Zabel wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you > know the content is safe > > Hi Steen, > > thank you for the patch. In addition to Andrew's comments, I have a > few > more below: > > On Wed, 2021-01-13 at

Re: [PATCH 2/3] reset: mchp: sparx5: add switch reset driver

2021-01-14 Thread Philipp Zabel
Hi Steen, thank you for the patch. In addition to Andrew's comments, I have a few more below: On Wed, 2021-01-13 at 21:19 +0100, Steen Hegelund wrote: > Signed-off-by: Steen Hegelund > --- > drivers/reset/Kconfig | 8 ++ > drivers/reset/Makefile | 1 + > dri

Re: [PATCH 2/3] reset: mchp: sparx5: add switch reset driver

2021-01-14 Thread Steen Hegelund
On Thu, 2021-01-14 at 00:23 +0100, Andrew Lunn wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you > know the content is safe > > > +static int sparx5_switch_reset(struct reset_controller_dev *rcdev, > > +   unsigned long id) > > +{ > > +

Re: [PATCH 2/3] reset: mchp: sparx5: add switch reset driver

2021-01-13 Thread Andrew Lunn
> +static int sparx5_switch_reset(struct reset_controller_dev *rcdev, > + unsigned long id) > +{ > + struct mchp_reset_context *ctx = > + container_of(rcdev, struct mchp_reset_context, reset_ctrl); > + u32 val; > + > + /* Make sure the core