Re: [PATCH 2/3] nvmem: mediatek: Add Mediatek EFUSE driver

2015-10-27 Thread andrew-ct chen
On Tue, 2015-10-27 at 13:32 +0800, andrew-ct chen wrote: > On Mon, 2015-10-26 at 09:56 +, Srinivas Kandagatla wrote: > > On 16/10/15 09:39, andrew-ct.c...@mediatek.com wrote: > > > From: Andrew-CT Chen > > > > > > Add Mediatek EFUSE driver to access hardware data like > > > thermal sensor cali

Re: [PATCH 2/3] nvmem: mediatek: Add Mediatek EFUSE driver

2015-10-26 Thread andrew-ct chen
On Mon, 2015-10-26 at 09:56 +, Srinivas Kandagatla wrote: > On 16/10/15 09:39, andrew-ct.c...@mediatek.com wrote: > > From: Andrew-CT Chen > > > > Add Mediatek EFUSE driver to access hardware data like > > thermal sensor calibration or HDMI impedance. > > > > Signed-off-by: Andrew-CT Chen >

Re: [PATCH 2/3] nvmem: mediatek: Add Mediatek EFUSE driver

2015-10-26 Thread Srinivas Kandagatla
On 26/10/15 10:28, Sascha Hauer wrote: On Mon, Oct 26, 2015 at 09:56:24AM +, Srinivas Kandagatla wrote: + .val_bits = 32, + .reg_stride = 4, +}; + +static int mtk_efuse_probe(struct platform_device *pdev) +{ + struct device *dev = &pdev->dev; + struct resource *res;

Re: [PATCH 2/3] nvmem: mediatek: Add Mediatek EFUSE driver

2015-10-26 Thread Sascha Hauer
On Mon, Oct 26, 2015 at 09:56:24AM +, Srinivas Kandagatla wrote: > >+.val_bits = 32, > >+.reg_stride = 4, > >+}; > >+ > >+static int mtk_efuse_probe(struct platform_device *pdev) > >+{ > >+struct device *dev = &pdev->dev; > >+struct resource *res; > >+struct nvmem_device *nv

Re: [PATCH 2/3] nvmem: mediatek: Add Mediatek EFUSE driver

2015-10-26 Thread Srinivas Kandagatla
On 16/10/15 09:39, andrew-ct.c...@mediatek.com wrote: From: Andrew-CT Chen Add Mediatek EFUSE driver to access hardware data like thermal sensor calibration or HDMI impedance. Signed-off-by: Andrew-CT Chen Dirver looks pretty simple, below are few minor nits. Please rebase this patch on t