Re: [PATCH 2/3] memcg: unify slab and other kmem pages charging

2015-10-19 Thread Michal Hocko
On Fri 16-10-15 17:19:32, Johannes Weiner wrote: [...] > I think it'd be better to have an outer function than a magic > parameter for the memcg lookup. Could we fold this in there? > > --- > Yes this makes sense. Thanks! > Signed-off-by: Johannes Weiner > --- > include/linux/memcontrol.h |

Re: [PATCH 2/3] memcg: unify slab and other kmem pages charging

2015-10-17 Thread Vladimir Davydov
On Fri, Oct 16, 2015 at 05:19:32PM -0700, Johannes Weiner wrote: ... > I think it'd be better to have an outer function than a magic > parameter for the memcg lookup. Could we fold this in there? Yeah, that looks neater. Thanks! Andrew, could you please fold this one too? > > --- > > Signed-of

Re: [PATCH 2/3] memcg: unify slab and other kmem pages charging

2015-10-16 Thread Johannes Weiner
Hi Vladimir, I'm late, but fwiw these patches are great simplifications. Thanks! One nit below: On Mon, Oct 05, 2015 at 01:21:42AM +0300, Vladimir Davydov wrote: > @@ -2404,36 +2376,59 @@ void __memcg_kmem_put_cache(struct kmem_cache *cachep) > css_put(&cachep->memcg_params.memcg->

Re: [PATCH 2/3] memcg: unify slab and other kmem pages charging

2015-10-08 Thread Michal Hocko
On Mon 05-10-15 01:21:42, Vladimir Davydov wrote: > We have memcg_kmem_charge and memcg_kmem_uncharge methods for charging > and uncharging kmem pages to memcg, but currently they are not used for > charging slab pages (i.e. they are only used for charging pages > allocated with alloc_kmem_pages).