Re: [PATCH 2/3] Input: spear-keyboard: Add clk_{un}prepare() support

2012-11-26 Thread Dmitry Torokhov
On Mon, Nov 26, 2012 at 09:57:45PM +0530, Viresh Kumar wrote: > On 20 November 2012 14:17, Dmitry Torokhov wrote: > > No, not really, it just does not work well with devm_* patches that got > > applied: on removal you unprepare clock as the very first operation and > > then devm_* does the rest wh

Re: [PATCH 2/3] Input: spear-keyboard: Add clk_{un}prepare() support

2012-11-26 Thread Viresh Kumar
On 20 November 2012 14:17, Dmitry Torokhov wrote: > No, not really, it just does not work well with devm_* patches that got > applied: on removal you unprepare clock as the very first operation and > then devm_* does the rest which is wrong order. > > I am looking at adding dem_* for clocks. I ha

Re: [PATCH 2/3] Input: spear-keyboard: Add clk_{un}prepare() support

2012-11-20 Thread Viresh Kumar
On 20 November 2012 14:17, Dmitry Torokhov wrote: > No, not really, it just does not work well with devm_* patches that got > applied: on removal you unprepare clock as the very first operation and > then devm_* does the rest which is wrong order. Nice. I don't expect the order would do anything

Re: [PATCH 2/3] Input: spear-keyboard: Add clk_{un}prepare() support

2012-11-20 Thread Dmitry Torokhov
On Tue, Nov 20, 2012 at 01:26:29PM +0530, Viresh Kumar wrote: > On 12 November 2012 11:27, Viresh Kumar wrote: > > On 8 November 2012 19:10, Viresh Kumar wrote: > >> From: Vipul Kumar Samar > >> > >> clk_{un}prepare is mandatory for platforms using common clock framework. > >> Because > >> for

Re: [PATCH 2/3] Input: spear-keyboard: Add clk_{un}prepare() support

2012-11-19 Thread Viresh Kumar
On 12 November 2012 11:27, Viresh Kumar wrote: > On 8 November 2012 19:10, Viresh Kumar wrote: >> From: Vipul Kumar Samar >> >> clk_{un}prepare is mandatory for platforms using common clock framework. >> Because >> for SPEAr we don't do anything in clk_{un}prepare() calls, just call them >> on

Re: [PATCH 2/3] Input: spear-keyboard: Add clk_{un}prepare() support

2012-11-11 Thread Viresh Kumar
On 8 November 2012 19:10, Viresh Kumar wrote: > From: Vipul Kumar Samar > > clk_{un}prepare is mandatory for platforms using common clock framework. > Because > for SPEAr we don't do anything in clk_{un}prepare() calls, just call them ones > in probe/remove. > > Signed-off-by: Vipul Kumar Samar