Re: [PATCH 2/3] Arm: dts: aspeed-g6: Add sgpio node

2020-10-28 Thread Joel Stanley
On Mon, 12 Oct 2020 at 04:56, Billy Tsai wrote: > > Hi Joel, > > Thanks for the review. > > On 2020/10/12, 12:35 PM, Joel Stanley wrote: > > > On Mon, 12 Oct 2020 at 03:32, Billy Tsai > wrote: > > > > > > This patch is used to add sgpiom and sgpios nodes and add compatible > > >

Re: [PATCH 2/3] Arm: dts: aspeed-g6: Add sgpio node

2020-10-25 Thread Andrew Jeffery
On Mon, 12 Oct 2020, at 15:05, Joel Stanley wrote: > On Mon, 12 Oct 2020 at 03:32, Billy Tsai wrote: > > > > This patch is used to add sgpiom and sgpios nodes and add compatiable > > string for sgpiom. > > You also need to add sgpios documentation to the bindings docs. > > Whenever you add ne

Re: [PATCH 2/3] Arm: dts: aspeed-g6: Add sgpio node

2020-10-11 Thread Billy Tsai
Hi Joel, Thanks for the review. On 2020/10/12, 12:35 PM, Joel Stanley wrote: > On Mon, 12 Oct 2020 at 03:32, Billy Tsai wrote: > > > > This patch is used to add sgpiom and sgpios nodes and add compatible > > string for sgpiom. > > You also need to add sgpios documentat

Re: [PATCH 2/3] Arm: dts: aspeed-g6: Add sgpio node

2020-10-11 Thread Joel Stanley
On Mon, 12 Oct 2020 at 03:32, Billy Tsai wrote: > > This patch is used to add sgpiom and sgpios nodes and add compatiable > string for sgpiom. You also need to add sgpios documentation to the bindings docs. Whenever you add new device tree bindings to the kernel tree you should add documentation