Re: [PATCH 2/2 v2] serial: Add support for Fintek F81216A LPC to 4 UART

2014-08-05 Thread Ricardo Ribalda Delgado
Hello Alan > We really want to handle it at the tty layer I think not at serial_core. > I have a patch for that and I'm playing with it but it's taking longer > than I hoped. > > In the mean time I think your patch #1 is ok except for the trivial > item that I'd prefer the struct serial_rs485 was

Re: [PATCH 2/2 v2] serial: Add support for Fintek F81216A LPC to 4 UART

2014-08-05 Thread One Thousand Gnomes
On Fri, 1 Aug 2014 14:28:11 +0200 Ricardo Ribalda Delgado wrote: > Hello > > >> Signed-off-by: Ricardo Ribalda Delgado > > > > This half of things looks good to me. > > > Thanks!, What about the other half? Would you accept a two step approach? > > 1st: add support for 8250_core > 2nd: handl

Re: [PATCH 2/2 v2] serial: Add support for Fintek F81216A LPC to 4 UART

2014-08-01 Thread Ricardo Ribalda Delgado
Hello >> Signed-off-by: Ricardo Ribalda Delgado > > This half of things looks good to me. Thanks!, What about the other half? Would you accept a two step approach? 1st: add support for 8250_core 2nd: handle rs485 ioctl on serial_core and modify all the other drivers to use that? (to avoid code

Re: [PATCH 2/2 v2] serial: Add support for Fintek F81216A LPC to 4 UART

2014-08-01 Thread One Thousand Gnomes
On Thu, 31 Jul 2014 21:22:26 +0200 Ricardo Ribalda Delgado wrote: > This patch lets you set the RS485 cappabilites of the device through > TIOCSRS485 and TIOCGRS485 as defined on Documentation/serial/serial-rs485.txt > > In order to probe the device, the PNP id and the device id is used. > > Si