Re: [PATCH 2/2 v2] sata highbank: add bit-banged SGPIO driver support

2013-06-05 Thread Mark Langsdorf
On 06/04/2013 03:32 PM, Tejun Heo wrote: > Hello, Mark. > > On Tue, Jun 04, 2013 at 10:09:41AM -0500, Mark Langsdorf wrote: >>> And tell ahci core sizeof(ecx_host_priv) some way, but really, just >>> having a plain pointer should be enough, I think. >> >> I think I want to do the opposite. For 90%

Re: [PATCH 2/2 v2] sata highbank: add bit-banged SGPIO driver support

2013-06-04 Thread Tejun Heo
Hello, Mark. On Tue, Jun 04, 2013 at 10:09:41AM -0500, Mark Langsdorf wrote: > > And tell ahci core sizeof(ecx_host_priv) some way, but really, just > > having a plain pointer should be enough, I think. > > I think I want to do the opposite. For 90% of the AHCI EM functions, > I want ecx_host_pri

Re: [PATCH 2/2 v2] sata highbank: add bit-banged SGPIO driver support

2013-06-04 Thread Mark Langsdorf
On 06/03/2013 03:37 PM, Tejun Heo wrote: > Hello, Mark. > > In general, please try to reply to reviews addressing each point. It > gives much better sense of what's going on to the reviewer and also > helps the reviewee to avoid misunderstandings or missing points. > >> +static DEFINE_SPINLOCK(s

Re: [PATCH 2/2 v2] sata highbank: add bit-banged SGPIO driver support

2013-06-03 Thread Tejun Heo
Hello, Mark. In general, please try to reply to reviews addressing each point. It gives much better sense of what's going on to the reviewer and also helps the reviewee to avoid misunderstandings or missing points. > +static DEFINE_SPINLOCK(sgpio_lock); > +#define SCLOCK