Re: [PATCH 2/2] watchdog: orion_wdt: use timer1 as a pretimeout

2019-03-05 Thread Guenter Roeck
On Tue, Mar 05, 2019 at 01:26:08AM +, Chris Packham wrote: > On 5/03/19 1:57 PM, Andrew Lunn wrote: > > On Tue, Mar 05, 2019 at 11:51:52AM +1300, Chris Packham wrote: > >> The orion watchdog can either reset the CPU or generate an interrupt. > >> The interrupt would be useful for debugging as i

Re: [PATCH 2/2] watchdog: orion_wdt: use timer1 as a pretimeout

2019-03-04 Thread Andrew Lunn
> > Hi Chris > > > > I had a quick look at other drivers implementing pre-timeout. They > > seem to call watchdog_notify_pretimeout(). I don't see that here? What > > happens when timer1 fires? > > > > It invokes the regular orion_wdt_irq(). On Armada-385 prior to this > change the irq was not

Re: [PATCH 2/2] watchdog: orion_wdt: use timer1 as a pretimeout

2019-03-04 Thread Chris Packham
On 5/03/19 1:57 PM, Andrew Lunn wrote: > On Tue, Mar 05, 2019 at 11:51:52AM +1300, Chris Packham wrote: >> The orion watchdog can either reset the CPU or generate an interrupt. >> The interrupt would be useful for debugging as it provides panic() >> output about the watchdog expiry, however if the

Re: [PATCH 2/2] watchdog: orion_wdt: use timer1 as a pretimeout

2019-03-04 Thread Andrew Lunn
On Tue, Mar 05, 2019 at 11:51:52AM +1300, Chris Packham wrote: > The orion watchdog can either reset the CPU or generate an interrupt. > The interrupt would be useful for debugging as it provides panic() > output about the watchdog expiry, however if the interrupt is used the > watchdog can't reset