Re: [PATCH 2/2] staging: et131x: Fix 64bit tx dma address handling

2012-10-18 Thread Mark Einon
On Thu, Oct 18, 2012 at 10:59:56AM +0100, Alan Cox wrote: > > > + > > > skb_headlen(skb), > > > + DMA_TO_DEVICE); > > > + desc[frag].addr_lo = dma_addr & >

Re: [PATCH 2/2] staging: et131x: Fix 64bit tx dma address handling

2012-10-18 Thread Alan Cox
> > + skb_headlen(skb), > > + DMA_TO_DEVICE); > > + desc[frag].addr_lo = dma_addr & 0x; > > + desc[frag].addr_hi = dma_

Re: [PATCH 2/2] staging: et131x: Fix 64bit tx dma address handling

2012-10-17 Thread Jeffrey Ladouceur
On Wed, Oct 17, 2012 at 5:15 PM, Mark Einon wrote: > The driver checks that the device can handle 64bit DMA addressing in > et131x_pci_setup(), but then assumes that the top dword of a tx dma > address is always zero when creating a dma mapping in nic_send_packet(). > Fix the mapping to use the hi