Re: [PATCH 2/2] regmap: Add range check in _regmap_raw_write()

2015-02-19 Thread Mark Brown
On Thu, Feb 19, 2015 at 11:11:58AM +, Srinivas Kandagatla wrote: > On 19/02/15 10:31, Mark Brown wrote: > >Your changelog doesn't correspond to what the code is actually doing > >here... what you're actually doing here is replacing an open coding of > >regmap_writeable() with calls to the fun

Re: [PATCH 2/2] regmap: Add range check in _regmap_raw_write()

2015-02-19 Thread Srinivas Kandagatla
On 19/02/15 10:31, Mark Brown wrote: On Thu, Feb 19, 2015 at 08:40:55AM +, Srinivas Kandagatla wrote: regmap_bulk_write() ends up using the path that invokes _regmap_raw_write(), however _regmap_raw_write() never checks if the registers that are accessed are actually within the accessible

Re: [PATCH 2/2] regmap: Add range check in _regmap_raw_write()

2015-02-19 Thread Mark Brown
On Thu, Feb 19, 2015 at 08:40:55AM +, Srinivas Kandagatla wrote: > regmap_bulk_write() ends up using the path that invokes _regmap_raw_write(), > however _regmap_raw_write() never checks if the registers that are accessed > are actually within the accessible range. This results in kernel crashe