Re: [PATCH 2/2] mn10300: Fix include dependency in irqflags.h

2013-06-17 Thread David Daney
On 06/17/2013 03:12 AM, Geert Uytterhoeven wrote: On Mon, Jun 17, 2013 at 9:07 AM, Geert Uytterhoeven wrote: On Sun, Jun 16, 2013 at 10:06 PM, wrote: From: David Daney We need to pick up the definition of raw_smp_processor_id() from asm/smp.h. For the !SMP case, we need to supply a defini

Re: [PATCH 2/2] mn10300: Fix include dependency in irqflags.h

2013-06-17 Thread Geert Uytterhoeven
On Mon, Jun 17, 2013 at 9:07 AM, Geert Uytterhoeven wrote: > On Sun, Jun 16, 2013 at 10:06 PM, wrote: >> From: David Daney >> >> We need to pick up the definition of raw_smp_processor_id() from >> asm/smp.h. For the !SMP case, we need to supply a definition of >> raw_smp_processor_id(). > > Th

Re: [PATCH 2/2] mn10300: Fix include dependency in irqflags.h

2013-06-17 Thread Geert Uytterhoeven
On Mon, Jun 17, 2013 at 11:07 AM, David Howells wrote: > ddaney.c...@gmail.com wrote: > >> #ifndef __ASSEMBLY__ >> -#include >> +/* linux/smp.h <- linux/irqflags.h needs asm/smp.h first */ >> +#include >> #endif > > If you make this change, is the #ifndef __ASSEMBLY__ still necessary, I > wond

Re: [PATCH 2/2] mn10300: Fix include dependency in irqflags.h

2013-06-17 Thread David Howells
ddaney.c...@gmail.com wrote: > #ifndef __ASSEMBLY__ > -#include > +/* linux/smp.h <- linux/irqflags.h needs asm/smp.h first */ > +#include > #endif If you make this change, is the #ifndef __ASSEMBLY__ still necessary, I wonder... David -- To unsubscribe from this list: send the line "unsubsc

Re: [PATCH 2/2] mn10300: Fix include dependency in irqflags.h

2013-06-17 Thread Geert Uytterhoeven
On Sun, Jun 16, 2013 at 10:06 PM, wrote: > From: David Daney > > We need to pick up the definition of raw_smp_processor_id() from > asm/smp.h. For the !SMP case, we need to supply a definition of > raw_smp_processor_id(). Thanks, this fixes the build! > Signed-off-by: David Daney Acked-by: