Re: [PATCH 2/2] mfd: ssbi: Use devm_* to simplify code

2013-06-03 Thread Stephen Boyd
On 06/03/13 01:10, Lee Jones wrote: >> Use devm_ioremap_resource and devm_kzalloc to simplify error >> paths and reduce lines of code. > The code looks fine, but you're actually doing a great deal more than > you describe in the commit message. Would you mind expanding? > > I.e: > >> +d

Re: [PATCH 2/2] mfd: ssbi: Use devm_* to simplify code

2013-06-03 Thread Lee Jones
> Use devm_ioremap_resource and devm_kzalloc to simplify error > paths and reduce lines of code. The code looks fine, but you're actually doing a great deal more than you describe in the commit message. Would you mind expanding? I.e: > + dev_err(&pdev->dev, "Unknown qcom,controller-t