Re: [PATCH 2/2] memstick: add support for legacy memorysticks

2012-10-01 Thread Maxim Levitsky
On Sat, 2012-09-29 at 19:20 +0200, Geert Uytterhoeven wrote: > On Wed, Sep 26, 2012 at 11:49 AM, Maxim Levitsky > wrote: > > --- /dev/null > > +++ b/drivers/memstick/core/ms_block.c > > > +#define pr_fmt(fmt) DRIVER_NAME ": " fmt > > + > > +#include > > +#include > > +#include > > +#include

Re: [PATCH 2/2] memstick: add support for legacy memorysticks

2012-09-29 Thread Geert Uytterhoeven
On Wed, Sep 26, 2012 at 11:49 AM, Maxim Levitsky wrote: > --- /dev/null > +++ b/drivers/memstick/core/ms_block.c > +#define pr_fmt(fmt) DRIVER_NAME ": " fmt > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#in

Re: [PATCH 2/2] memstick: add support for legacy memorysticks

2012-09-26 Thread Tejun Heo
On Wed, Sep 26, 2012 at 11:49:01AM +0200, Maxim Levitsky wrote: > Based partially on MS standard spec quotes from Alex Dubov. > > As any code that works with user data this driver isn't > recommended to use to write cards that contain valuable data. > > It tries its best though to avoid data corr

Re: [PATCH 2/2] memstick: add support for legacy memorysticks

2012-09-25 Thread Maxim Levitsky
On Tue, 2012-09-25 at 12:38 -0700, Tejun Heo wrote: > Hello, Maxim. > > On Tue, Sep 25, 2012 at 09:26:13PM +0200, Maxim Levitsky wrote: > > > Probably not the best idea to use a name this generic in driver code. > > > linux/scatterlist.h likely might wanna use the name. > > > > Lets not go this r

Re: [PATCH 2/2] memstick: add support for legacy memorysticks

2012-09-25 Thread Tejun Heo
Hello, Maxim. On Tue, Sep 25, 2012 at 09:26:13PM +0200, Maxim Levitsky wrote: > > Probably not the best idea to use a name this generic in driver code. > > linux/scatterlist.h likely might wanna use the name. > > Lets not go this route again. I already once submitted these, and had > a share of pr

Re: [PATCH 2/2] memstick: add support for legacy memorysticks

2012-09-25 Thread Maxim Levitsky
On Tue, 2012-09-25 at 11:25 -0700, Tejun Heo wrote: > Hello, > > On Tue, Sep 25, 2012 at 10:38:46AM +0200, Maxim Levitsky wrote: > > diff --git a/drivers/memstick/core/ms_block.c > > b/drivers/memstick/core/ms_block.c > > new file mode 100644 > > index 000..318e40b > > --- /dev/null > > +++

Re: [PATCH 2/2] memstick: add support for legacy memorysticks

2012-09-25 Thread Tejun Heo
Hello, On Tue, Sep 25, 2012 at 10:38:46AM +0200, Maxim Levitsky wrote: > diff --git a/drivers/memstick/core/ms_block.c > b/drivers/memstick/core/ms_block.c > new file mode 100644 > index 000..318e40b > --- /dev/null > +++ b/drivers/memstick/core/ms_block.c > @@ -0,0 +1,2422 @@ > +/* > + * ms