Re: [PATCH 2/2] kallsyms: Revert back to 128 max symbol length

2013-11-13 Thread Michal Marek
On 12.11.2013 22:55, Joe Mario wrote: > Given there are 5 other locations in the code that need to be changed > from [128] to [KSYM_NAME_LEN], and that we still haven't found Fengguang's > problem yet, I'd be in favor of letting Michal's revert patch 2/2 go > forward. It's in kbuild.git#kbu

Re: [PATCH 2/2] kallsyms: Revert back to 128 max symbol length

2013-11-12 Thread Joe Mario
On 11/11/2013 09:17 AM, Andi Kleen wrote: On Mon, Nov 11, 2013 at 02:40:36PM +0100, Michal Marek wrote: This reverts commits f3462aa (Kbuild: Handle longer symbols in kallsyms.c) and eea0e9c (kbuild: Increase kallsyms max symbol length) except for the added overflow check. The reason is a regres

Re: [PATCH 2/2] kallsyms: Revert back to 128 max symbol length

2013-11-11 Thread Michal Marek
On Mon, Nov 11, 2013 at 06:17:15AM -0800, Andi Kleen wrote: > On Mon, Nov 11, 2013 at 02:40:36PM +0100, Michal Marek wrote: > > This reverts commits > > f3462aa (Kbuild: Handle longer symbols in kallsyms.c) and > > eea0e9c (kbuild: Increase kallsyms max symbol length) > > except for the added overf

Re: [PATCH 2/2] kallsyms: Revert back to 128 max symbol length

2013-11-11 Thread Andi Kleen
On Mon, Nov 11, 2013 at 02:40:36PM +0100, Michal Marek wrote: > This reverts commits > f3462aa (Kbuild: Handle longer symbols in kallsyms.c) and > eea0e9c (kbuild: Increase kallsyms max symbol length) > except for the added overflow check. The reason is a regression caused > by increasing the buffe