Re: [PATCH 2/2] clk: rockchip: fix the rk3399 sdmmc sample shift

2016-05-13 Thread Doug Anderson
Shawn, On Fri, May 13, 2016 at 12:46 AM, Shawn Lin wrote: >> This should be possible to verify in one of two ways. If the TRM has >> a typo and things truly _do_ start at 0 instead of 1, then: >> >> 1. There will be roughly mirrors of valid ranges. >> 2. Things won't match up if we change tuning

Re: [PATCH 2/2] clk: rockchip: fix the rk3399 sdmmc sample shift

2016-05-13 Thread Shawn Lin
在 2016/5/13 12:36, Doug Anderson 写道: Shawn, On Thu, May 12, 2016 at 4:47 PM, Shawn Lin wrote: 在 2016/5/13 7:10, Brian Norris 写道: On Thu, May 12, 2016 at 11:03:17AM -0700, Doug Anderson wrote: Just like every other Rockhip device, the MMC "_sample" clocks should have a shift of 0, not a shi

Re: [PATCH 2/2] clk: rockchip: fix the rk3399 sdmmc sample shift

2016-05-12 Thread Doug Anderson
Shawn, On Thu, May 12, 2016 at 4:47 PM, Shawn Lin wrote: > 在 2016/5/13 7:10, Brian Norris 写道: >> >> On Thu, May 12, 2016 at 11:03:17AM -0700, Doug Anderson wrote: >>> >>> Just like every other Rockhip device, the MMC "_sample" clocks should >>> have a shift of 0, not a shift of 1. The rk3399 TRM

Re: [PATCH 2/2] clk: rockchip: fix the rk3399 sdmmc sample shift

2016-05-12 Thread Shawn Lin
在 2016/5/13 7:10, Brian Norris 写道: On Thu, May 12, 2016 at 11:03:17AM -0700, Doug Anderson wrote: Just like every other Rockhip device, the MMC "_sample" clocks should have a shift of 0, not a shift of 1. The rk3399 TRM agrees. Presumably these values were set to 0 because of a typo. I'll se

Re: [PATCH 2/2] clk: rockchip: fix the rk3399 sdmmc sample shift

2016-05-12 Thread Brian Norris
On Thu, May 12, 2016 at 11:03:17AM -0700, Doug Anderson wrote: > Just like every other Rockhip device, the MMC "_sample" clocks should > have a shift of 0, not a shift of 1. The rk3399 TRM agrees. Presumably > these values were set to 0 because of a typo. I'll semi-disagree about the TRM: the TR