Re: [PATCH 2/2] ath11k: Handle errors if peer creation fails

2020-11-10 Thread Kalle Valo
Alex Dewar wrote: > ath11k_peer_create() is called without its return value being checked, > meaning errors will be unhandled. Add missing check and, as the mutex is > unconditionally unlocked on leaving this function, simplify the exit > path. > > Addresses-Coverity-ID: 1497531 ("Code maintaina

Re: [PATCH 2/2] ath11k: Handle errors if peer creation fails

2020-11-07 Thread Alex Dewar
On Sat, Nov 07, 2020 at 01:23:30PM +0200, Kalle Valo wrote: > Alex Dewar writes: > > > On Tue, Oct 06, 2020 at 10:26:28AM +0300, Kalle Valo wrote: > >> Alex Dewar writes: > >> > >> > ath11k_peer_create() is called without its return value being checked, > >> > meaning errors will be unhandled.

Re: [PATCH 2/2] ath11k: Handle errors if peer creation fails

2020-11-07 Thread Kalle Valo
Alex Dewar writes: > On Tue, Oct 06, 2020 at 10:26:28AM +0300, Kalle Valo wrote: >> Alex Dewar writes: >> >> > ath11k_peer_create() is called without its return value being checked, >> > meaning errors will be unhandled. Add missing check and, as the mutex is >> > unconditionally unlocked on le

Re: [PATCH 2/2] ath11k: Handle errors if peer creation fails

2020-10-06 Thread Alex Dewar
On Tue, Oct 06, 2020 at 10:26:28AM +0300, Kalle Valo wrote: > Alex Dewar writes: > > > ath11k_peer_create() is called without its return value being checked, > > meaning errors will be unhandled. Add missing check and, as the mutex is > > unconditionally unlocked on leaving this function, simplif

Re: [PATCH 2/2] ath11k: Handle errors if peer creation fails

2020-10-06 Thread Kalle Valo
Alex Dewar writes: > ath11k_peer_create() is called without its return value being checked, > meaning errors will be unhandled. Add missing check and, as the mutex is > unconditionally unlocked on leaving this function, simplify the exit > path. > > Addresses-Coverity-ID: 1497531 ("Code maintaina