Re: [PATCH 2/2] aoe: use min() to simplify the code

2013-08-02 Thread Andy Shevchenko
On Thu, 2013-08-01 at 21:13 -0400, Ed Cashin wrote: > Thanks. > > I agree that we could do that. I'm not sure it increases readability to put > this much stuff on one line, though. What is the motivation? Motivation is to explicitly show that that operation is to calculate a minimum of two th

Re: [PATCH 2/2] aoe: use min() to simplify the code

2013-08-01 Thread Ed Cashin
Thanks. I agree that we could do that. I'm not sure it increases readability to put this much stuff on one line, though. What is the motivation? On Aug 1, 2013, at 8:28 AM, Andy Shevchenko wrote: > min() incorporates condition in it. In our case we could do assignment and > make a choice at o