RE: [PATCH 2/2] aio: propogate post-EIOCBQUEUED errors to completion event

2007-02-21 Thread Ananiev, Leonid I
-aio; Linux Kernel Mailing List; Benjamin LaHaise; Suparna >bhattacharya; Andrew Morton; Badari Pulavarty >Subject: Re: [PATCH 2/2] aio: propogate post-EIOCBQUEUED errors to completion event > > >On Feb 21, 2007, at 12:35 AM, Ken Chen wrote: > >> On 2/20/07, Ananiev, Leonid &

Re: [PATCH 2/2] aio: propogate post-EIOCBQUEUED errors to completion event

2007-02-21 Thread Zach Brown
This is an interesting trick, but I'd like to consider hard whether the added complexity is worth it. Could you list the various other cases you have in mind which would want to use it ? I'm happy to report that the sync case and the invalidate_inode_pages2_range() case are the only two wh

Re: [PATCH 2/2] aio: propogate post-EIOCBQUEUED errors to completion event

2007-02-21 Thread Zach Brown
On Feb 21, 2007, at 12:35 AM, Ken Chen wrote: On 2/20/07, Ananiev, Leonid <[EMAIL PROTECTED]> wrote: 1) mem=1G in kernel boot param if you have more 2) unmount; mk2fs; mount 3) dd if=/dev/zero of= bs=1M count=1200 4) aiostress -s 1200m -O -o 2 -i 1 -r 16k 5) if i++<50 goto 2). Would you ple

Re: [PATCH 2/2] aio: propogate post-EIOCBQUEUED errors to completion event

2007-02-21 Thread Suparna Bhattacharya
On Mon, Feb 19, 2007 at 01:38:35PM -0800, Zach Brown wrote: > aio: propogate post-EIOCBQUEUED errors to completion event > > This addresses an oops reported by Leonid Ananiev <[EMAIL PROTECTED]> > as archived at http://lkml.org/lkml/2007/2/8/337. > > O_DIRECT kicks off bios and returns -EIOCBQUEU

RE: [PATCH 2/2] aio: propogate post-EIOCBQUEUED errors to completion event

2007-02-21 Thread Ananiev, Leonid I
L PROTECTED]; linux-kernel@vger.kernel.org; Benjamin LaHaise; Suparna bhattacharya; Andrew Morton Subject: Re: [PATCH 2/2] aio: propogate post-EIOCBQUEUED errors to completion event On 2/20/07, Ananiev, Leonid <[EMAIL PROTECTED]> wrote: > 1) mem=1G in kernel boot param if you have more > 2

Re: [PATCH 2/2] aio: propogate post-EIOCBQUEUED errors to completion event

2007-02-21 Thread Ken Chen
On 2/20/07, Ananiev, Leonid <[EMAIL PROTECTED]> wrote: 1) mem=1G in kernel boot param if you have more 2) unmount; mk2fs; mount 3) dd if=/dev/zero of= bs=1M count=1200 4) aiostress -s 1200m -O -o 2 -i 1 -r 16k 5) if i++<50 goto 2). Would you please instrument the call chain of invalidate_compl

RE: [PATCH 2/2] aio: propogate post-EIOCBQUEUED errors to completion event

2007-02-20 Thread Ananiev, Leonid I
-o 2 -i 1 -r 16k 5) if i++<50 goto 2). Leonid -Original Message- From: Chris Mason [mailto:[EMAIL PROTECTED] Sent: Tuesday, February 20, 2007 8:55 PM To: Ananiev, Leonid I Cc: Zach Brown; [EMAIL PROTECTED]; linux-kernel@vger.kernel.org; Benjamin LaHaise; Suparna bhattacharya; Andrew Morto

Re: [PATCH 2/2] aio: propogate post-EIOCBQUEUED errors to completion event

2007-02-20 Thread Zach Brown
On Feb 20, 2007, at 9:33 AM, Ananiev, Leonid I wrote: There is change in the patch which is uncommented in preface. Now aio_ring_insert_entry() is not called if req->ki_users>=1. Before was called. Could you comment it? It is described in the patch description, though perhaps not explicitly

Re: [PATCH 2/2] aio: propogate post-EIOCBQUEUED errors to completion event

2007-02-20 Thread Chris Mason
On Tue, Feb 20, 2007 at 08:17:51PM +0300, Ananiev, Leonid I wrote: > aio-stress command lines used for test > 1) mem=1G in kernel boot param if you have more > 2) mk2fs for test_file > 3) dd if=/dev/zero of= bs=1M count=1200 > 4) aiostress -s 1200m -o 2 -i 1 -r 16k > Sorry, this aio-stress comma

RE: [PATCH 2/2] aio: propogate post-EIOCBQUEUED errors to completion event

2007-02-20 Thread Ananiev, Leonid I
There is change in the patch which is uncommented in preface. Now aio_ring_insert_entry() is not called if req->ki_users>=1. Before was called. Could you comment it? Leonid -Original Message- From: Zach Brown [mailto:[EMAIL PROTECTED] Sent: Tuesday, February 20, 2007 12:39 AM To: [EMAIL P

RE: [PATCH 2/2] aio: propogate post-EIOCBQUEUED errors to completion event

2007-02-20 Thread Ananiev, Leonid I
, 2007 8:04 PM To: Ananiev, Leonid I Cc: Zach Brown; [EMAIL PROTECTED]; linux-kernel@vger.kernel.org; Benjamin LaHaise; Suparna bhattacharya; Andrew Morton Subject: Re: [PATCH 2/2] aio: propogate post-EIOCBQUEUED errors to completion event On Tue, Feb 20, 2007 at 07:57:49PM +0300, Ananiev, Leonid I

Re: [PATCH 2/2] aio: propogate post-EIOCBQUEUED errors to completion event

2007-02-20 Thread Chris Mason
On Tue, Feb 20, 2007 at 07:57:49PM +0300, Ananiev, Leonid I wrote: > Zach> This addresses an oops reported by Leonid Ananiev > <[EMAIL PROTECTED]> > Zach> as archived at http://lkml.org/lkml/2007/2/8/337. > > Zach> This was tested by running O_DIRECT aio-stress concurrently with > buffered rea

RE: [PATCH 2/2] aio: propogate post-EIOCBQUEUED errors to completion event

2007-02-20 Thread Ananiev, Leonid I
Zach> This addresses an oops reported by Leonid Ananiev <[EMAIL PROTECTED]> Zach> as archived at http://lkml.org/lkml/2007/2/8/337. Zach> This was tested by running O_DIRECT aio-stress concurrently with buffered reads The oops was with aio-stress only running in the loop WITHOUT buffered or m

Re: [PATCH 2/2] aio: propogate post-EIOCBQUEUED errors to completion event

2007-02-19 Thread Zach Brown
Zach> So this patch introduces a helper, aio_propogate_error(), ...which is spelled incorrectly: aio_propagate_error. Man, I am batting 1000! Randy also made fun of my 'intead'. Zach> which queues post-submission errors in the iocb so that they are Zach> given to the user completion event

Re: [PATCH 2/2] aio: propogate post-EIOCBQUEUED errors to completion event

2007-02-19 Thread Jeff Moyer
==> On Mon, 19 Feb 2007 13:38:35 -0800 (PST), Zach Brown <[EMAIL PROTECTED]> said: Zach> This addresses an oops reported by Leonid Ananiev <[EMAIL PROTECTED]> Zach> as archived at http://lkml.org/lkml/2007/2/8/337. [snip] Zach> So this patch introduces a helper, aio_propogate_error(), ...which