Re: [PATCH 2/2] UML - Add stack usage monitoring

2007-06-20 Thread Jeff Dike
On Tue, Jun 19, 2007 at 01:14:41PM -0700, Andrew Morton wrote: > Oh well. Your new code should really be generic, utilising the > stack-page-zeroing which CONFIG_DEBUG_STACK_USAGE enables. There's nothing > UML-specific about it. > > low_water_lock and lowest_to_date should be static to check_st

Re: [PATCH 2/2] UML - Add stack usage monitoring

2007-06-20 Thread Jeff Dike
On Tue, Jun 19, 2007 at 12:57:07PM -0700, Randy Dunlap wrote: > Kconfig help text is indented 2 more spaces (by convention or > CodingStyle). OK, will fix. > > + if(*p != 0) > > if (*p != NULL) p is int *, so that's a int version pointer comparision. > or >

Re: [PATCH 2/2] UML - Add stack usage monitoring

2007-06-19 Thread Andrew Morton
On Tue, 19 Jun 2007 15:50:03 -0400 Jeff Dike <[EMAIL PROTECTED]> wrote: > On Tue, Jun 19, 2007 at 11:54:22AM -0700, Andrew Morton wrote: > > On Tue, 19 Jun 2007 14:42:45 -0400 > > Jeff Dike <[EMAIL PROTECTED]> wrote: > > > > > Add a machanism to see how much of a kernel stack is used. This > > >

Re: [PATCH 2/2] UML - Add stack usage monitoring

2007-06-19 Thread Randy Dunlap
On Tue, 19 Jun 2007 15:50:03 -0400 Jeff Dike wrote: > Add a machanism to see how much of a kernel stack is used. This > allocates zeroed stacks and sees where the lowest non-zero byte is on > process exit. It keeps track of the lowest value and logs values as > they get lower. > > Signed-off-by

Re: [PATCH 2/2] UML - Add stack usage monitoring

2007-06-19 Thread Jeff Dike
On Tue, Jun 19, 2007 at 11:54:22AM -0700, Andrew Morton wrote: > On Tue, 19 Jun 2007 14:42:45 -0400 > Jeff Dike <[EMAIL PROTECTED]> wrote: > > > Add a machanism to see how much of a kernel stack is used. This > > allocates zeroed stacks and sees where the lowest non-zero byte is on > > process ex

Re: [PATCH 2/2] UML - Add stack usage monitoring

2007-06-19 Thread Andrew Morton
On Tue, 19 Jun 2007 14:42:45 -0400 Jeff Dike <[EMAIL PROTECTED]> wrote: > Add a machanism to see how much of a kernel stack is used. This > allocates zeroed stacks and sees where the lowest non-zero byte is on > process exit. It keeps track of the lowest value and logs values as > they get lower