Re: [PATCH 2/2] Fix copy-paste bug: assign from src struct not dest

2015-01-07 Thread Arend van Spriel
On 01/07/15 23:16, Johannes Berg wrote: On Wed, 2015-01-07 at 20:18 +0100, Giel van Schijndel wrote: IMO the aligned block of code has the significant advantage of taking advantage of humans' ability to spot things that break a pattern. Which in this case becomes *very* visible when properly al

Re: [PATCH 2/2] Fix copy-paste bug: assign from src struct not dest

2015-01-07 Thread Johannes Berg
On Wed, 2015-01-07 at 20:18 +0100, Giel van Schijndel wrote: > IMO the aligned block of code has the significant advantage of taking > advantage of humans' ability to spot things that break a pattern. Which > in this case becomes *very* visible when properly aligned, because > without the alignmen

Re: [PATCH 2/2] Fix copy-paste bug: assign from src struct not dest

2015-01-07 Thread Giel van Schijndel
On Mon, Jan 05, 2015 at 10:54:31 +0100, Johannes Berg wrote: > On Sun, 2015-01-04 at 19:00 +0100, Giel van Schijndel wrote: >> --- >> drivers/net/wireless/ti/wlcore/acx.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/net/wireless/ti/wlcore/acx.c >> b/drivers

Re: [PATCH 2/2] Fix copy-paste bug: assign from src struct not dest

2015-01-05 Thread Johannes Berg
On Sun, 2015-01-04 at 19:00 +0100, Giel van Schijndel wrote: > --- > drivers/net/wireless/ti/wlcore/acx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/ti/wlcore/acx.c > b/drivers/net/wireless/ti/wlcore/acx.c > index beb354c..93a2fa8 100644 > --- a

Re: [PATCH 2/2] Fix copy-paste bug: assign from src struct not dest

2015-01-04 Thread Giel van Schijndel
On Sun, Jan 04, 2015 at 19:00:23 +0100, Giel van Schijndel wrote: > --- Forgot to: Signed-off-by: Giel van Schijndel -- Met vriendelijke groet, With kind regards, Giel van Schijndel signature.asc Description: Digital signature