Re: [PATCH 2/2] Changes to existing files for 0PF FPGA board.

2015-06-26 Thread Rob Landley
On 06/19/2015 05:49 PM, Greg Kroah-Hartman wrote: > On Fri, Jun 19, 2015 at 04:57:00PM -0500, Rob Landley wrote: >> On 06/18/2015 12:59 PM, Greg Kroah-Hartman wrote: >>> On Thu, Jun 18, 2015 at 10:19:19AM -0700, Rob Landley wrote: Changes to existing files to add 0pf j2 board support. >>>

Re: [PATCH 2/2] Changes to existing files for 0PF FPGA board.

2015-06-26 Thread Greg Kroah-Hartman
On Fri, Jun 19, 2015 at 04:57:00PM -0500, Rob Landley wrote: > On 06/18/2015 12:59 PM, Greg Kroah-Hartman wrote: > > On Thu, Jun 18, 2015 at 10:19:19AM -0700, Rob Landley wrote: > >> Changes to existing files to add 0pf j2 board support. > >> > > > > That's the second worse commit message and subj

Re: [PATCH 2/2] Changes to existing files for 0PF FPGA board.

2015-06-21 Thread Yoshinori Sato
On Sun, 21 Jun 2015 05:13:06 +0900, Rob Landley wrote: > > On 06/20/2015 03:00 AM, Geert Uytterhoeven wrote: > > Hi Rob, > > > > On Sat, Jun 20, 2015 at 12:11 AM, Rob Landley wrote: > >> On 06/18/2015 02:36 PM, Geert Uytterhoeven wrote: > >>> On Thu, Jun 18, 2015 at 7:19 PM, Rob Landley wrote:

Re: [PATCH 2/2] Changes to existing files for 0PF FPGA board.

2015-06-20 Thread Geert Uytterhoeven
Hi Rob, On Sat, Jun 20, 2015 at 10:13 PM, Rob Landley wrote: >>> (Now the reason _I_ thought you'd reject it had more to do with not >>> having converted it to device tree yet, and things on that level. But I >> >> Sh is an existing supported architecture, so DT is not a hard requirement. > > Yea

Re: [PATCH 2/2] Changes to existing files for 0PF FPGA board.

2015-06-20 Thread Rob Landley
On 06/20/2015 03:00 AM, Geert Uytterhoeven wrote: > Hi Rob, > > On Sat, Jun 20, 2015 at 12:11 AM, Rob Landley wrote: >> On 06/18/2015 02:36 PM, Geert Uytterhoeven wrote: >>> On Thu, Jun 18, 2015 at 7:19 PM, Rob Landley wrote: Changes to existing files to add 0pf j2 board support. >>> >>> Th

Re: [PATCH 2/2] Changes to existing files for 0PF FPGA board.

2015-06-20 Thread Geert Uytterhoeven
Hi Rob, On Sat, Jun 20, 2015 at 12:11 AM, Rob Landley wrote: > On 06/18/2015 02:36 PM, Geert Uytterhoeven wrote: >> On Thu, Jun 18, 2015 at 7:19 PM, Rob Landley wrote: >>> Changes to existing files to add 0pf j2 board support. >> >> Thanks for your patch! >> >> Like Greg already said, splitting

Re: [PATCH 2/2] Changes to existing files for 0PF FPGA board.

2015-06-19 Thread Rob Landley
[Trimmed greg at what I'm interpreting as his request.] On 06/18/2015 02:36 PM, Geert Uytterhoeven wrote: > Hi Rob, > > On Thu, Jun 18, 2015 at 7:19 PM, Rob Landley wrote: >> Changes to existing files to add 0pf j2 board support. > > Thanks for your patch! > > Like Greg already said, splitting

Re: [PATCH 2/2] Changes to existing files for 0PF FPGA board.

2015-06-19 Thread Rob Landley
On 06/18/2015 12:59 PM, Greg Kroah-Hartman wrote: > On Thu, Jun 18, 2015 at 10:19:19AM -0700, Rob Landley wrote: >> Changes to existing files to add 0pf j2 board support. >> > > That's the second worse commit message and subject: line I've read > today. > > And there's no signed off by line. My

Re: [PATCH 2/2] Changes to existing files for 0PF FPGA board.

2015-06-18 Thread Geert Uytterhoeven
Hi Rob, On Thu, Jun 18, 2015 at 7:19 PM, Rob Landley wrote: > Changes to existing files to add 0pf j2 board support. Thanks for your patch! Like Greg already said, splitting it up in logical parts and providing useful patch descriptions would be highly appreciated. > diff --git a/arch/sh/Makef

Re: [PATCH 2/2] Changes to existing files for 0PF FPGA board.

2015-06-18 Thread Steven Rostedt
On Thu, 18 Jun 2015 10:59:31 -0700 Greg Kroah-Hartman wrote: > On Thu, Jun 18, 2015 at 10:19:19AM -0700, Rob Landley wrote: > > Changes to existing files to add 0pf j2 board support. > > > > That's the second worse commit message and subject: line I've read > today. Only the second worse today

Re: [PATCH 2/2] Changes to existing files for 0PF FPGA board.

2015-06-18 Thread Greg Kroah-Hartman
On Thu, Jun 18, 2015 at 10:19:19AM -0700, Rob Landley wrote: > Changes to existing files to add 0pf j2 board support. > That's the second worse commit message and subject: line I've read today. And there's no signed off by line. And there was no 1/2 patch sent. And, most importantly: > diff -